Sign upLogin

wmakeev/moysklad

View on GitHub
Star
src/tools/buildQuery.js

Summary

Maintainability
D
2 days
Test Coverage
A
100%

Function buildQuery has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function buildQuery(query) {
  // совместимость с remap 1.2
  if (query.expand && query.limit == null) {
    query.limit = 100
  }
Severity: Minor
Found in src/tools/buildQuery.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    module.exports = function buildQuery(query) {
  // совместимость с remap 1.2
  if (query.expand && query.limit == null) {
    query.limit = 100
  }
    Severity: Major
    Found in src/tools/buildQuery.js and 1 other location - About 2 days to fix
    bundle/umd/moysklad.js on lines 1466..1511

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 357.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const addQueryPart = (res, key) => val => {
  if (val === null) {
    res.push([key, ''])
  } else if (val === undefined) {
    return undefined
    Severity: Major
    Found in src/tools/buildQuery.js and 1 other location - About 4 hrs to fix
    bundle/umd/moysklad.js on lines 1452..1464

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Replace '']) with ""]);
    Open

        res.push([key, ''])
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

    }
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'filter' with "filter"
    Open

            case key === 'filter':
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

    }
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        res.push([key, encodeURIComponent(val)])
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'Значение·поля·строки·запроса·должно·быть·строкой,·числом,·логическим·значением,·null·или·undefined' with "Значение·поля·строки·запроса·должно·быть·строкой,·числом,·логическим·значением,·null·или·undefined"
    Open

          'Значение поля строки запроса должно быть строкой, числом, логическим значением, null или undefined'
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace ';' with ";"
    Open

                  .join(';')
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'use·strict' with "use·strict";
    Open

    'use strict'
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace ?·${o[0]}${o[1]·!=·null·?·','·+·o[1]·:·''with··?·${o[0]}${o[1]·!=·null·?·","·+·o[1]·:·""
    Open

                      ? `${o[0]}${o[1] != null ? ',' + o[1] : ''}`
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace ··················:·o with ····················:·o)
    Open

                      : o
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              query[key].forEach(addPart)
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              break
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          return res
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace './isPlainObject') with "./isPlainObject");
    Open

    const isPlainObject = require('./isPlainObject')
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        return undefined
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          const addPart = addQueryPart(res, key)
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'order' with "order"
    Open

            case key === 'order' && query.order instanceof Array:
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace '../errors') with "../errors");
    Open

    const { MoyskladError } = require('../errors')
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        )
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              if (isPlainObject(query.filter)) addPart(buildFilter(query.filter))
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'string',·'number',·'boolean' with "string",·"number",·"boolean"
    Open

      } else if (['string', 'number', 'boolean'].indexOf(typeof val) === -1) {
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              break
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'Поле·filter·запроса·должно·быть·строкой·или·объектом' with "Поле·filter·запроса·должно·быть·строкой·или·объектом"
    Open

                  'Поле filter запроса должно быть строкой или объектом'
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

                )
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              addPart(query[key])
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace './buildFilter') with "./buildFilter");
    Open

    const buildFilter = require('./buildFilter')
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ··(
    Open

                    o instanceof Array
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              break
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              )
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        query.limit = 100
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace '&') with "&");
    Open

        .join('&')
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ⏎················
    Open

                  .map(o =>
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'string')·addPart(query.filter) with "string")·addPart(query.filter);
    Open

              else if (typeof query.filter === 'string') addPart(query.filter)
    Severity: Minor
    Found in src/tools/buildQuery.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status