wonderlic/swagger-validation

View on GitHub
lib/validation/parameters/string.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function validateString has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

var validateString = function(param, value) {
  var isRequired = helper.isRequired(param, value);
  if (isRequired) {
    return isRequired;
  }
Severity: Minor
Found in lib/validation/parameters/string.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return helper.errorReturn("%s is not valid based on the pattern %s", [param.name, param.pattern]);
Severity: Major
Found in lib/validation/parameters/string.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return helper.errorReturn("%s is specified with an invalid pattern %s", [param.name, param.pattern]);
    Severity: Major
    Found in lib/validation/parameters/string.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return helper.successReturn(value);
      Severity: Major
      Found in lib/validation/parameters/string.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status