woothemes/woocommerce

View on GitHub
assets/js/admin/marketplace-suggestions.js

Summary

Maintainability
D
2 days
Test Coverage

File marketplace-suggestions.js has 327 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global marketplace_suggestions, ajaxurl, Cookies */
( function( $, marketplace_suggestions, ajaxurl ) {
    $( function() {
        if ( 'undefined' === typeof marketplace_suggestions ) {
            return;
Severity: Minor
Found in assets/js/admin/marketplace-suggestions.js - About 3 hrs to fix

    Function displaySuggestions has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function displaySuggestions( marketplaceSuggestionsApiData ) {
                var usedSuggestionsContexts = [];
    
                // iterate over all suggestions containers, rendering promos
                $( '.marketplace-suggestions-container' ).each( function() {
    Severity: Major
    Found in assets/js/admin/marketplace-suggestions.js - About 2 hrs to fix

      Function renderListItem has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              function renderListItem( context, product, promoted, slug, iconUrl, title, copy, url, linkText, linkIsButton, allowDismiss ) {
      Severity: Major
      Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

        Function addURLParameters has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function addURLParameters( context, url ) {
                    var urlParams = marketplace_suggestions.in_app_purchase_params;
                    urlParams.utm_source = 'unknown';
                    urlParams.utm_campaign = 'marketplacesuggestions';
                    urlParams.utm_medium = 'product';
        Severity: Minor
        Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

          Function renderLinkout has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function renderLinkout( context, product, promoted, slug, url, text, isButton ) {
                      var linkoutButton = document.createElement( 'a' );
          
                      var utmUrl = addURLParameters( context, url );
                      linkoutButton.setAttribute( 'href', utmUrl );
          Severity: Minor
          Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

            Function renderSuggestionContent has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function renderSuggestionContent( slug, title, copy ) {
                        var container = document.createElement( 'div' );
            
                        container.classList.add( 'marketplace-suggestion-container-content' );
            
            
            Severity: Minor
            Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

              Function dismissSuggestion has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function dismissSuggestion( context, product, promoted, url, suggestionSlug ) {
                          // hide the suggestion in the UI
                          var selector = '[data-suggestion-slug=' + suggestionSlug + ']';
                          $( selector ).fadeOut( function() {
                              $( this ).remove();
              Severity: Minor
              Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

                Function renderSuggestionCTA has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        function renderSuggestionCTA( context, product, promoted, slug, url, linkText, linkIsButton, allowDismiss ) {
                Severity: Major
                Found in assets/js/admin/marketplace-suggestions.js - About 1 hr to fix

                  Function renderLinkout has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          function renderLinkout( context, product, promoted, slug, url, text, isButton ) {
                  Severity: Major
                  Found in assets/js/admin/marketplace-suggestions.js - About 50 mins to fix

                    Function renderDismissButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            function renderDismissButton( context, product, promoted, url, suggestionSlug ) {
                    Severity: Minor
                    Found in assets/js/admin/marketplace-suggestions.js - About 35 mins to fix

                      Function dismissSuggestion has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              function dismissSuggestion( context, product, promoted, url, suggestionSlug ) {
                      Severity: Minor
                      Found in assets/js/admin/marketplace-suggestions.js - About 35 mins to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                                window.wcTracks.recordEvent( 'marketplace_suggestion_displayed', {
                                                    suggestion_slug: suggestionsToDisplay[ i ].slug,
                                                    context: context,
                                                    product: suggestionsToDisplay[ i ].product || '',
                                                    promoted: suggestionsToDisplay[ i ].promoted || '',
                        Severity: Major
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 2 hrs to fix
                        assets/js/admin/marketplace-suggestions.js on lines 421..427

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 85.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                                window.wcTracks.recordEvent( 'marketplace_suggestion_displayed', {
                                                    suggestion_slug: suggestionsToDisplay[ i ].slug,
                                                    context: context,
                                                    product: suggestionsToDisplay[ i ].product || '',
                                                    promoted: suggestionsToDisplay[ i ].promoted || '',
                        Severity: Major
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 2 hrs to fix
                        assets/js/admin/marketplace-suggestions.js on lines 397..403

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 85.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    window.wcTracks.recordEvent( 'marketplace_suggestion_dismissed', {
                                        suggestion_slug: suggestionSlug,
                                        context: context,
                                        product: product || '',
                                        promoted: promoted || '',
                        Severity: Minor
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 55 mins to fix
                        assets/js/admin/marketplace-suggestions.js on lines 133..139

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        window.wcTracks.recordEvent( 'marketplace_suggestion_clicked', {
                                            suggestion_slug: slug,
                                            context: context,
                                            product: product || '',
                                            promoted: promoted || '',
                        Severity: Minor
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 55 mins to fix
                        assets/js/admin/marketplace-suggestions.js on lines 51..57

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 54.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    promos = _.filter( promos, function( promo ) {
                                        return ! _.contains( marketplace_suggestions.active_plugins, promo.product );
                                    } );
                        Severity: Minor
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 40 mins to fix
                        assets/js/admin/marketplace-suggestions.js on lines 261..263

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    promos = _.filter( promos, function( promo ) {
                                        return ! _.contains( marketplace_suggestions.dismissed_suggestions, promo.slug );
                                    } );
                        Severity: Minor
                        Found in assets/js/admin/marketplace-suggestions.js and 1 other location - About 40 mins to fix
                        assets/js/admin/marketplace-suggestions.js on lines 266..268

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 48.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status