Sign upLogin

workcraft/workcraft

View on GitHub
Star

Showing 1,901 of 2,492 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (currentNode instanceof VisualConnection) {
                VisualConnection vc = (VisualConnection) currentNode;
                AffineTransform rootToLocalTransform = TransformHelper.getTransformFromRoot(vc);
                vc.setSplitPoint(rootToLocalTransform.transform(currentPoint, null));
            }
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ConnectionTool.java and 1 other location - About 35 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ConnectionTool.java on lines 261..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            createReplicaReadArcs(slot.mem.zero, Arrays.asList(slot.tl.dn.riseList.get(2), slot.tl.dn.riseList.get(1)), +6.0, 0.0);
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java and 1 other location - About 35 mins to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java on lines 1097..1097

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (mConnection == null) {
            MathNode mFirst = getReferencedComponent(first);
            MathNode mSecond = getReferencedComponent(second);
            mConnection = getMathModel().connect(mFirst, mSecond);
        }
Severity: Minor
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/VisualXmas.java and 1 other location - About 35 mins to fix
workcraft/StgPlugin/src/org/workcraft/plugins/stg/VisualStg.java on lines 144..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if (node instanceof VisualComponent) {
                mathNode = ((VisualComponent) node).getReferencedComponent();
            } else if (node instanceof VisualConnection) {
                mathNode = ((VisualConnection) node).getReferencedConnection();
            }
Severity: Major
Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java and 4 other locations - About 35 mins to fix
workcraft/PetriPlugin/src/org/workcraft/plugins/petri/VisualPetri.java on lines 135..139
workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/VisualLocality.java on lines 22..26
workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/VisualLocality.java on lines 58..62
workcraft/StgPlugin/src/org/workcraft/plugins/stg/VisualStg.java on lines 199..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        try {
            VisualConnection connection = circuit.connect(fromNode, toNode);
            connection.copyShape(toConnection);
            connection.copyStyle(toConnection);
        } catch (InvalidConnectionException e) {
Severity: Minor
Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/commands/SplitGateTransformationCommand.java and 1 other location - About 35 mins to fix
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/commands/SplitGateTransformationCommand.java on lines 238..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public Cnf visit(One node) {
            negation = !negation;
            Cnf result = negation ? new Cnf(new CnfClause()) : new Cnf();
            negation = !negation;
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/formula/cnf/CnfGenerator.java and 1 other location - About 35 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/formula/dnf/DnfGenerator.java on lines 17..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

            if (node instanceof VisualComponent) {
                refNode = ((VisualComponent) node).getReferencedComponent();
            } else if (node instanceof VisualLocality) {
                refNode = ((VisualLocality) node).getLocality();
            }
Severity: Major
Found in workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/VisualLocality.java and 4 other locations - About 35 mins to fix
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/tools/InitialisationAnalyserTool.java on lines 263..267
workcraft/PetriPlugin/src/org/workcraft/plugins/petri/VisualPetri.java on lines 135..139
workcraft/PolicyPlugin/src/org/workcraft/plugins/policy/VisualLocality.java on lines 22..26
workcraft/StgPlugin/src/org/workcraft/plugins/stg/VisualStg.java on lines 199..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public void write(byte[] b, int off, int len) {
            if (systemErr != null) {
                systemErr.write(b, off, len);
            }
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/gui/ErrorWindow.java and 1 other location - About 35 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/gui/OutputWindow.java on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    private Set<VisualFunctionComponent> getBuffers(VisualCircuit circuit) {
        Set<VisualFunctionComponent>  result = new HashSet<>();
        for (VisualFunctionComponent component : circuit.getVisualFunctionComponents()) {
            if (component.isBuffer()) {
                result.add(component);
Severity: Major
Found in workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/TransformationCommandTests.java and 4 other locations - About 35 mins to fix
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/TransformationCommandTests.java on lines 126..134
workcraft/CircuitPlugin/test-src/org/workcraft/plugins/circuit/TransformationCommandTests.java on lines 156..164
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/RelationAlgorithm.java on lines 112..120
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/RelationAlgorithm.java on lines 125..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                            for (int k = 0; k < side2[j].length; k++) {
                                list.add(not(side2[j][k]));
                            }
Severity: Minor
Found in workcraft/CpogPlugin/src/org/workcraft/plugins/cpog/sat/CleverCnfGenerator.java and 1 other location - About 35 mins to fix
workcraft/CpogPlugin/src/org/workcraft/plugins/cpog/sat/CleverCnfGenerator.java on lines 54..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    protected void pageSelection(final GraphEditor editor) {
        VisualModel model = editor.getModel();
        if (!model.getSelection().isEmpty()) {
            beforeSelectionModification(editor);
            model.groupPageSelection();
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SelectionTool.java and 2 other locations - About 35 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SelectionTool.java on lines 710..717
workcraft/WorkcraftCore/src/org/workcraft/gui/tools/SelectionTool.java on lines 719..726

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (!trueExcited) {
            g.setStroke(new BasicStroke(strokeWidth2));
            g.draw(trueInnerShape);
            g.setStroke(new BasicStroke(strokeWidth4));
            g.draw(trueMarkerShape);
Severity: Minor
Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/VisualControlRegister.java and 1 other location - About 35 mins to fix
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/VisualControlRegister.java on lines 131..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    @Override
    public void save(Config config) {
        config.setBoolean(keyShowContacts, getShowContacts());
        config.setDouble(keyBorderWidth, getBorderWidth());
        config.setDouble(keyWireWidth, getWireWidth());
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/XmasSettings.java and 3 other locations - About 35 mins to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/SONSettings.java on lines 85..91
workcraft/WorkcraftCore/src/org/workcraft/plugins/builtin/settings/AnalysisDecorationSettings.java on lines 66..72
workcraft/WorkcraftCore/src/org/workcraft/plugins/builtin/settings/RandomLayoutSettings.java on lines 65..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

package org.workcraft.plugins.stg.commands;

import org.workcraft.dom.Container;
import org.workcraft.plugins.stg.Signal;
import org.workcraft.plugins.stg.SignalTransition;
Severity: Minor
Found in workcraft/StgPlugin/src/org/workcraft/plugins/stg/commands/InsertOutputTransformationCommand.java and 2 other locations - About 35 mins to fix
workcraft/StgPlugin/src/org/workcraft/plugins/stg/commands/InsertInputTransformationCommand.java on lines 1..27
workcraft/StgPlugin/src/org/workcraft/plugins/stg/commands/InsertInternalTransformationCommand.java on lines 1..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            for (FunctionContact fc: new ArrayList<>(getFunctionContacts())) {
                BooleanFormula setFunction = FormulaUtils.remove(fc.getSetFunction(), contact);
                BooleanFormula resetFunction = FormulaUtils.remove(fc.getResetFunction(), contact);
                fc.setBothFunctions(setFunction, resetFunction);
            }
Severity: Minor
Found in workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/FunctionComponent.java and 1 other location - About 35 mins to fix
workcraft/CircuitPlugin/src/org/workcraft/plugins/circuit/observers/FunctionConsistencySupervisor.java on lines 34..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (firstNode instanceof VisualConnection) {
                VisualConnection vc = (VisualConnection) firstNode;
                AffineTransform rootToLocalTransform = TransformHelper.getTransformFromRoot(vc);
                vc.setSplitPoint(rootToLocalTransform.transform(firstPoint, null));
            }
Severity: Minor
Found in workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ConnectionTool.java and 1 other location - About 35 mins to fix
workcraft/WorkcraftCore/src/org/workcraft/gui/tools/ConnectionTool.java on lines 266..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

package org.workcraft.plugins.cpog.converters;

import org.workcraft.dom.converters.DefaultModelConverter;
import org.workcraft.dom.math.MathNode;
import org.workcraft.plugins.cpog.Vertex;
Severity: Minor
Found in workcraft/CpogPlugin/src/org/workcraft/plugins/cpog/converters/CpogToGraphConverter.java and 2 other locations - About 35 mins to fix
workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/converters/FsmToGraphConverter.java on lines 1..26
workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/converters/GraphToFsmConverter.java on lines 1..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            if ((c1Node instanceof Place) && savedState.containsKey(c1Node)) {
                boolean computed = savedState.get(c1Node) > 0;
                node.getReferencedComponent().setComputed(computed);
            }
Severity: Minor
Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/DfsSimulationTool.java and 2 other locations - About 35 mins to fix
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/DfsSimulationTool.java on lines 103..106
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/tools/DfsSimulationTool.java on lines 109..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (((first instanceof VisualChannelPlace) && (second instanceof VisualCondition))
                || ((first instanceof VisualCondition) && (second instanceof VisualChannelPlace))) {
            throw new InvalidConnectionException("Connections between channel place and condition are not valid (A/Syn Communication)");
        }
Severity: Minor
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/VisualSON.java and 2 other locations - About 35 mins to fix
workcraft/PetriPlugin/src/org/workcraft/plugins/petri/VisualPetri.java on lines 73..76
workcraft/PetriPlugin/src/org/workcraft/plugins/petri/VisualPetri.java on lines 98..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public void setMutexProtocol(Mutex.Protocol value) {
        if ((mutexProtocol != value) && (value != null)) {
            mutexProtocol = value;
            sendNotification(new PropertyChangedEvent(this, PROPERTY_MUTEX_PROTOCOL));
        }
Severity: Minor
Found in workcraft/StgPlugin/src/org/workcraft/plugins/stg/StgPlace.java and 2 other locations - About 35 mins to fix
workcraft/StgPlugin/src/org/workcraft/plugins/stg/SignalTransition.java on lines 61..66
workcraft/StgPlugin/src/org/workcraft/plugins/stg/SignalTransition.java on lines 74..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language