Sign upLogin

workcraft/workcraft

View on GitHub
Star

Showing 1,901 of 2,492 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void forwardDFSDurations(LinkedList<Time> visited) throws TimeOutOfBoundsException {
        for (Time t : getCausalPostset(visited.getLast(), scenario.getNodes(net))) {
            Interval i = null;
            // set default value for any t with unspecified duration.
            if (!t.getDuration().isSpecified()) {
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 145..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (VisualPushRegister rSuccNode : dfs.getRPostset(node, VisualPushRegister.class)) {
            BinaryRegisterStg rSuccNodeStg = getPushRegisterStg(rSuccNode);
            Connection connection = dfs.getConnection(node, rSuccNode);
            if ((connection instanceof VisualControlConnection)
                    && ((VisualControlConnection) connection).getReferencedConnection().isInverting()) {
Severity: Major
Found in workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/stg/DfsToStgConverter.java and 1 other location - About 2 hrs to fix
workcraft/DfsPlugin/src/org/workcraft/plugins/dfs/stg/DfsToStgConverter.java on lines 979..993

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 152.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    void dotLayoutSettingsTest() {
        final Framework framework = Framework.getInstance();
        String prefix = "DotLayoutSettings";
Severity: Major
Found in workcraft/WorkcraftCore/test-src/org/workcraft/plugins/LayoutSettingsTest.java and 1 other location - About 2 hrs to fix
workcraft/PcompPlugin/test-src/org/workcraft/plugins/pcomp/PcompSettingsTest.java on lines 18..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @Test
    void pcompSettingsTest() {
        final Framework framework = Framework.getInstance();
        String prefix = "Tools.pcomp";
Severity: Major
Found in workcraft/PcompPlugin/test-src/org/workcraft/plugins/pcomp/PcompSettingsTest.java and 1 other location - About 2 hrs to fix
workcraft/WorkcraftCore/test-src/org/workcraft/plugins/LayoutSettingsTest.java on lines 20..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function apropos(substring, fileName) {
    if (arguments.length > 1) {
        write(getHelp(substring, true), fileName);
    } else if (arguments.length > 0) {
        write(getHelp(substring, true));
Severity: Major
Found in workcraft/WorkcraftCore/res/scripts/core-help.js and 1 other location - About 2 hrs to fix
workcraft/WorkcraftCore/res/scripts/core-help.js on lines 15..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function help(substring, fileName) {
    if (arguments.length > 1) {
        write(getHelp(substring, false), fileName);
    } else if (arguments.length > 0) {
        write(getHelp(substring, false));
Severity: Major
Found in workcraft/WorkcraftCore/res/scripts/core-help.js and 1 other location - About 2 hrs to fix
workcraft/WorkcraftCore/res/scripts/core-help.js on lines 29..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void drawFault(DrawRequest r) {
        if (SONSettings.isErrorTracing()) {
            Graphics2D g = r.getGraphics();
            GlyphVector glyphVector = null;
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/elements/VisualEvent.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/elements/VisualBlock.java on lines 78..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @Override
    public void drawFault(DrawRequest r) {
        if (SONSettings.isErrorTracing()) {
            Graphics2D g = r.getGraphics();
            GlyphVector glyphVector = null;
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/elements/VisualBlock.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/elements/VisualEvent.java on lines 64..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (int i = 1; i < size; i++) {
            if (printoutput) {
                System.out.println("p_" + id + "i_trdy0  t_" + id + "i_trdyplus" + i);
                System.out.println("t_" + id + "i_trdyplus" + i + " p_" + id + "i_trdy1");
            }
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/commands/PNetGenerationCommand.java and 1 other location - About 2 hrs to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/commands/PNetGenerationCommand.java on lines 736..743

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (int i = 1; i < size; i++) {
            if (printoutput) {
                System.out.println("p_" + id + "o_irdy0  t_" + id + "o_irdyplus" + i);
                System.out.println("t_" + id + "o_irdyplus" + i + " p_" + id + "o_irdy1");
            }
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/commands/PNetGenerationCommand.java and 1 other location - About 2 hrs to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/commands/PNetGenerationCommand.java on lines 747..754

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Collection<Condition> forwardSearch(Node node) {
        Collection<Condition> result = new HashSet<>();
        Stack<Node> stack = new Stack<>();
        Collection<Node> visit = new HashSet<>();
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BSONAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BSONAlg.java on lines 277..302

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private Collection<Condition> backWardSearch(Node node) {
        Collection<Condition> result = new HashSet<>();
        Stack<Node> stack = new Stack<>();
        Collection<Node> visit = new HashSet<>();
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BSONAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/BSONAlg.java on lines 250..275

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void estimateStartTime(Node n) throws TimeOutOfBoundsException, TimeEstimationException {

        if (((Time) n).getStartTime().isSpecified()) {
            return;
        }
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 45..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void estimateEndTime(Node n) throws TimeOutOfBoundsException, TimeEstimationException {
        if (((Time) n).getEndTime().isSpecified()) {
            return;
        }
        LinkedList<Time> visited = new LinkedList<>();
Severity: Major
Found in workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java and 1 other location - About 2 hrs to fix
workcraft/SonPlugin/src/org/workcraft/plugins/son/algorithm/DFSEstimationAlg.java on lines 70..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 148.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void connectSourceStg(VisualSourceComponent component) throws InvalidConnectionException {
        SourceStg sourceStg = getSourceStg(component);
        if (sourceStg != null) {
            VisualXmasContact oContact = null;
            for (VisualXmasContact contact: component.getContacts()) {
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java and 1 other location - About 2 hrs to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java on lines 461..482

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private void connectSinkStg(VisualSinkComponent component) throws InvalidConnectionException {
        SinkStg sinkStg = getSinkStg(component);
        if (sinkStg != null) {
            VisualXmasContact iContact = null;
            for (VisualXmasContact contact: component.getContacts()) {
Severity: Major
Found in workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java and 1 other location - About 2 hrs to fix
workcraft/XmasPlugin/src/org/workcraft/plugins/xmas/stg/XmasToStgConverter.java on lines 401..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private PropertyDescriptor getPlayer1SymbolProperty(VisualPlayer1 event) {
        return new PropertyDeclaration<>(String.class, Player1.PROPERTY_SYMBOL,
                value -> {
                    Symbol symbol = null;
                    if (!value.isEmpty()) {
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 2 other locations - About 2 hrs to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java on lines 86..109
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 167..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private PropertyDescriptor getPlayer0SymbolProperty(VisualPlayer0 event) {
        return new PropertyDeclaration<>(String.class, Player0.PROPERTY_SYMBOL,
                value -> {
                    Symbol symbol = null;
                    if (!value.isEmpty()) {
Severity: Major
Found in workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java and 2 other locations - About 2 hrs to fix
workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java on lines 86..109
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 198..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private PropertyDescriptor getVertexSymbolProperty(VisualVertex event) {
        return new PropertyDeclaration<>(String.class, Vertex.PROPERTY_SYMBOL,
                value -> {
                    Symbol symbol = null;
                    if (!value.isEmpty()) {
Severity: Major
Found in workcraft/GraphPlugin/src/org/workcraft/plugins/graph/VisualGraph.java and 2 other locations - About 2 hrs to fix
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 167..190
workcraft/ParityPlugin/src/org/workcraft/plugins/parity/VisualParity.java on lines 198..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                value -> {
                    String newName = value.getText();
                    Fst mathFst = fst.getMathModel();
                    Node node = mathFst.getNodeByReference(newName);
                    Collection<SignalEvent> events = mathFst.getSignalEvents(signal);
Severity: Major
Found in workcraft/FstPlugin/src/org/workcraft/plugins/fst/FstPropertyHelper.java and 1 other location - About 2 hrs to fix
workcraft/FsmPlugin/src/org/workcraft/plugins/fsm/FsmPropertyHelper.java on lines 39..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language