Sign upLogin

wtg/shuttle-signups

View on GitHub
Star
routes/signup-shuttle.js

Summary

Maintainability
B
5 hrs
Test Coverage

Avoid too many return statements within this function.
Open

                return;
Severity: Major
Found in routes/signup-shuttle.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return;
    Severity: Major
    Found in routes/signup-shuttle.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return;
      Severity: Major
      Found in routes/signup-shuttle.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in routes/signup-shuttle.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return;
          Severity: Major
          Found in routes/signup-shuttle.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return;
            Severity: Major
            Found in routes/signup-shuttle.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return;
              Severity: Major
              Found in routes/signup-shuttle.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (riders.indexOf(rcs_id) !== -1) {
                res.send("You've already signed up for shuttle " + shuttleID + ". To add guests, you'll need to unsignup, and then resignup with your guests.");
                return;
            }
            else if (waitlist.indexOf(rcs_id) !== -1) {
                Severity: Major
                Found in routes/signup-shuttle.js and 1 other location - About 1 hr to fix
                routes/signup-shuttle.js on lines 66..73

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (riders.indexOf(rcs_id) !== -1) {
                res.send("You've already signed up for shuttle " + shuttleID);
                return;
            }
            else if (waitlist.indexOf(rcs_id) !== -1) {
                Severity: Major
                Found in routes/signup-shuttle.js and 1 other location - About 1 hr to fix
                routes/signup-shuttle.js on lines 121..128

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status