Sign upLogin

wvulibraries/databases

View on GitHub
Star

Showing 3 of 3 total issues

File database.rb has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Database < ApplicationRecord
  # TABLE NAME
  # -----------------------------------------------------
  self.table_name = :database_list
Severity: Minor
Found in app/models/database.rb - About 2 hrs to fix

    Class Database has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Database < ApplicationRecord
  # TABLE NAME
  # -----------------------------------------------------
  self.table_name = :database_list
    Severity: Minor
    Found in app/models/database.rb - About 2 hrs to fix

      Method import has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def import(csv_file)
    ActiveRecord::Base.transaction do
      CSV.foreach(csv_file,  headers: true,  header_converters: :symbol, converters: :all) do |db|
        db_hash = db.to_h
        db_hash[:created_at] = Time.zone.now
      Severity: Minor
      Found in app/services/database_import_service.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language