Sign upLogin

xUnholy/go-proxy

View on GitHub
Star

Showing 2 of 10 total issues

Function UpdateFile has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

func UpdateFile(cntlmValues map[string]string) error {
    replaceCommented := []string{"PassLM", "PassNT", "PassNTLMv2"}
    file, err := os.GetConfigurationPath(runtime.GOOS)
    if err != nil {
        return err
Severity: Minor
Found in internal/cntlm/update.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ValidateRequiredFields has 5 return statements (exceeds 4 allowed).
Open

func ValidateRequiredFields(c *Configuration) error {
    if c.Proxy.Credentials.Username == "" {
        return fmt.Errorf("username is a required field")
    }
    if len(c.Proxy.ProxyAddress) == 0 {
Severity: Major
Found in internal/config/profile.go - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language