Sign upLogin

xebialabs-community/xld-azure-app-services-plugin

View on GitHub
Star

Showing 15 of 32 total issues

AzureClient has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class AzureClient:
    def __init__(self, subscription_id, tenant_id, client_id, client_key, ftp_user, ftp_password, base_url, management_url,
                 active_directory_url):
        self.subscription_id = subscription_id
        self.tenant_id = tenant_id
Severity: Major
Found in src/main/jython/azure_app_services/client/__init__.py - About 7 hrs to fix

    File __init__.py has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #
# Copyright 2019 XEBIALABS
#
# Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
#
    Severity: Minor
    Found in src/main/jython/azure_app_services/client/__init__.py - About 4 hrs to fix

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, subscription_id, tenant_id, client_id, client_key, ftp_user, ftp_password, base_url, management_url,
      Severity: Major
      Found in src/main/jython/azure_app_services/client/__init__.py - About 1 hr to fix

        Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, platform_32bit=True, always_on=False, net_framework_version="", php_version="", python_version="",
        Severity: Major
        Found in src/main/jython/azure_app_services/client/__init__.py - About 1 hr to fix

          Function discover_resource_groups has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def discover_resource_groups(client, ctx, descriptor, webapp_descriptor, service_plan_descriptor, base_id):
          Severity: Minor
          Found in src/main/jython/azure_app_services/inspect.py - About 45 mins to fix

            Function update_db_conn_settings has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def update_db_conn_settings(self, resource_group, site_name, location,
            Severity: Minor
            Found in src/main/jython/azure_app_services/client/__init__.py - About 45 mins to fix

              Function discover_service_plans has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def discover_service_plans(client, ctx, descriptor, base_id, resource_group):
              Severity: Minor
              Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

                Function deploy_triggered_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def deploy_triggered_webjob(self, webjob_name, site_name, executable_file_name, schedule, zip_file_path):
                Severity: Minor
                Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                  Function create_app_service_plan has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def create_app_service_plan(self, resource_group, name, location, sku, worker_size):
                  Severity: Minor
                  Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                    Function perform_discovery has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def perform_discovery(subscription, ctx, resource_group_descriptor, web_app_module_descriptor, service_plan_descriptor):
                    Severity: Minor
                    Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

                      Function deploy_continuous_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def deploy_continuous_webjob(self, webjob_name, site_name, executable_file_name, is_singleton, zip_file_path):
                      Severity: Minor
                      Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                        Function discover_webapps has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def discover_webapps(client, ctx, descriptor, base_id, resource_group):
                        Severity: Minor
                        Found in src/main/jython/azure_app_services/inspect.py - About 35 mins to fix

                          Function _deploy_webjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def _deploy_webjob(self, webjob_name, site_name, executable_file_name, zip_file_path, webjob_service_type="triggeredwebjobs" ):
                          Severity: Minor
                          Found in src/main/jython/azure_app_services/client/__init__.py - About 35 mins to fix

                            Function _execute_http_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                def _execute_http_request(self, request_builder, error_checking=True):
        response = self._execute_http_request_return_response(request_builder)
        if error_checking:
            AzureClient._check_return_code(response)
        else:
                            Severity: Minor
                            Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function update_general_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                def update_general_settings(self, resource_group, site_name, location, settings):
        wsuc_details = WebSiteUpdateConfigurationDetails()
        wsuc_details.setUse32BitWorkerProcess(settings.platform_32bit)
        wsuc_details.setAlwaysOn(settings.always_on)
        if settings.java_version:
                            Severity: Minor
                            Found in src/main/jython/azure_app_services/client/__init__.py - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language