Sign upLogin

xmatters/upgreat

View on GitHub
Star

Showing 4 of 6 total issues

Function upgrade has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

const upgrade = (log, flags) => async dep => {
  log(
    `  - ${dep.name}: ${dep.version} -> ${dep.targetVersion} (${diffColor[
      dep.diff
    ](dep.diff)})`,
Severity: Minor
Found in src/lib/up/upgrade.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function upgrade has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const upgrade = (log, flags) => async dep => {
  log(
    `  - ${dep.name}: ${dep.version} -> ${dep.targetVersion} (${diffColor[
      dep.diff
    ](dep.diff)})`,
Severity: Minor
Found in src/lib/up/upgrade.js - About 1 hr to fix

    Function run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async run() {
    const { flags } = this.parse(Plan)

    const packageJsonPath = 'package.json'
    Severity: Minor
    Found in src/lib/plan/index.js - About 1 hr to fix

      Function checkDep has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const checkDep = async ({ name, version, dev }) => {
  // starts with ~ or ^ or 1 or more digits
  // followed by a . and 1 or more digits
  // followed by a . and 1 or more digits
  // can take some - and 1 or more digits at the end
      Severity: Minor
      Found in src/lib/plan/checkDep.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language