Sign upLogin

xwp/stream

View on GitHub
Star
ui/js/alerts.js

Summary

Maintainability
C
1 day
Test Coverage

Function setupSelectTwo has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        var setupSelectTwo = function setupSelectTwo( id ) {
            var $target = $( id );
            $target.find( '.select2-select.connector_or_context' ).each(
                function( k, el ) {
                    $( el ).select2(
Severity: Major
Found in ui/js/alerts.js - About 2 hrs to fix

    File alerts.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* globals jQuery, streamAlerts, inlineEditPost */
jQuery(
    function( $ ) {
        'use strict';
        var $post_row,
    Severity: Minor
    Found in ui/js/alerts.js - About 2 hrs to fix

      Function edit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              inlineEditPost.edit = function( id ) {
            // "call" the original WP edit function
            // we don't want to leave WordPress hanging
            $wp_inline_edit.apply( this, arguments );
      Severity: Minor
      Found in ui/js/alerts.js - About 1 hr to fix

        Function save_new_alert has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                var save_new_alert = function save_new_alert( e ) {
            e.preventDefault();
            $( '#add-new-alert' ).find( 'p.submit.inline-edit-save span.spinner' ).css( 'visibility', 'visible' );
            var data = {
                action: 'save_new_alert',
        Severity: Minor
        Found in ui/js/alerts.js - About 1 hr to fix

          Function getActions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  var getActions = function( connector ) {
            var trigger_action = $( '#wp_stream_trigger_action' );
            trigger_action.empty();
            trigger_action.prop( 'disabled', true );
          Severity: Minor
          Found in ui/js/alerts.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                for ( var key in actions ) {
                        if ( actions.hasOwnProperty( key ) ) {
                            var value = actions[key];
                            var option = $( '<option/>', { value: key, text: value } );
                            trigger_action.append( option );
            Severity: Major
            Found in ui/js/alerts.js and 1 other location - About 1 hr to fix
            ui/js/exclude.js on lines 411..417

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                if ( connector && 0 < connector.indexOf( '-' ) ) {
                        var connector_split = connector.split( '-' );
                        connector = connector_split[0];
                    }
            Severity: Minor
            Found in ui/js/alerts.js and 1 other location - About 40 mins to fix
            ui/js/exclude.js on lines 60..63

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status