Sign upLogin

yahoo/kobold-core

View on GitHub
Star
lib/storageAdapter/fileStorageAdapter.js

Summary

Maintainability
D
1 day
Test Coverage

FileStorageAdapter has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

    {
        /**
         * Initializes the source-adapter
         *
         * @method initialize
Severity: Minor
Found in lib/storageAdapter/fileStorageAdapter.js - About 3 hrs to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getCurrentApprovedScreen: function (name) {
            return this.getPromise().then(function () {
                return this._readImage(path.join(this._getApprovedPath(), name + '.png'));
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 2 hrs to fix
lib/storageAdapter/fileStorageAdapter.js on lines 354..358
lib/storageAdapter/fileStorageAdapter.js on lines 394..398

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getHighlightScreen: function (name) {
            return this.getPromise().then(function () {
                return this._readImage(path.join(this._getHighlightPath(), name + '.png'));
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 2 hrs to fix
lib/storageAdapter/fileStorageAdapter.js on lines 275..279
lib/storageAdapter/fileStorageAdapter.js on lines 354..358

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getBuildScreen: function (name) {
            return this.getPromise().then(function () {
                return this._readImage(path.join(this._getBuildPath(), name + '.png'));
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 2 hrs to fix
lib/storageAdapter/fileStorageAdapter.js on lines 275..279
lib/storageAdapter/fileStorageAdapter.js on lines 394..398

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getCurrentApprovedScreenNames: function () {
            return this.getPromise().then(function () {
                return this._readDirAndFilter(this._getApprovedPath());
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 1 hr to fix
lib/storageAdapter/fileStorageAdapter.js on lines 341..345
lib/storageAdapter/fileStorageAdapter.js on lines 381..385

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getBuildScreenNames: function () {
            return this.getPromise().then(function () {
                return this._readDirAndFilter(this._getBuildPath());
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 1 hr to fix
lib/storageAdapter/fileStorageAdapter.js on lines 262..266
lib/storageAdapter/fileStorageAdapter.js on lines 381..385

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        getHighlightScreenNames: function () {
            return this.getPromise().then(function () {
                return this._readDirAndFilter(this._getHighlightPath());
            }.bind(this));
        },
Severity: Major
Found in lib/storageAdapter/fileStorageAdapter.js and 2 other locations - About 1 hr to fix
lib/storageAdapter/fileStorageAdapter.js on lines 262..266
lib/storageAdapter/fileStorageAdapter.js on lines 341..345

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status