yamadapc/pivotal-to-github

View on GitHub

Showing 5 of 6 total issues

Function createGithubTicket has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

exports.createGithubTicket = rateLimit(1, 2000, function(github, repo, user, ticket, people, cb) {
  //console.log(people); process.exit(1);
  function getComments(ticket) {
    return '### Comments\n\n' + ticket.comments.map(function(comment) {
      var commenter = people[comment.personId] ? people[comment.personId].name : comment.personId;
Severity: Minor
Found in lib/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createGithubTicket has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.createGithubTicket = rateLimit(1, 2000, function(github, repo, user, ticket, people, cb) {
  //console.log(people); process.exit(1);
  function getComments(ticket) {
    return '### Comments\n\n' + ticket.comments.map(function(comment) {
      var commenter = people[comment.personId] ? people[comment.personId].name : comment.personId;
Severity: Minor
Found in lib/index.js - About 1 hr to fix

    Function createGithubTickets has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.createGithubTickets = function(token, repo, user, tickets, people, cb) {
      if(!cb) cb = function() {};
    
      var github = new GitHubApi({
        version: '3.0.0',
    Severity: Minor
    Found in lib/index.js - About 1 hr to fix

      Function createGithubTicket has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      exports.createGithubTicket = rateLimit(1, 2000, function(github, repo, user, ticket, people, cb) {
      Severity: Minor
      Found in lib/index.js - About 45 mins to fix

        Function createGithubTickets has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        exports.createGithubTickets = function(token, repo, user, tickets, people, cb) {
        Severity: Minor
        Found in lib/index.js - About 45 mins to fix
          Severity
          Category
          Status
          Source
          Language