Sign upLogin

yamb/yamb

View on GitHub
Star
lib/yamb/proto/methods/save.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function(priv, opts) {
  return function *save() {
    if (this.id && utils.empty(this.json(true))) {
      // nothing to update
      return this;
Severity: Minor
Found in lib/yamb/proto/methods/save.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(priv, opts) {
  return function *save() {
    if (this.id && utils.empty(this.json(true))) {
      // nothing to update
      return this;
Severity: Major
Found in lib/yamb/proto/methods/save.js - About 3 hrs to fix

    Function save has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function *save() {
    if (this.id && utils.empty(this.json(true))) {
      // nothing to update
      return this;
    }
    Severity: Major
    Found in lib/yamb/proto/methods/save.js - About 3 hrs to fix

      There are no issues that match your filters.

      Category
      Status