Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star
lib/rules/no-array-index-key.js

Summary

Maintainability
D
3 days
Test Coverage

Function create has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

  create(context) {
    // --------------------------------------------------------------------------
    // Public
    // --------------------------------------------------------------------------
    const indexParamNames = [];
Severity: Minor
Found in lib/rules/no-array-index-key.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 175 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create(context) {
    // --------------------------------------------------------------------------
    // Public
    // --------------------------------------------------------------------------
    const indexParamNames = [];
Severity: Major
Found in lib/rules/no-array-index-key.js - About 7 hrs to fix

    Function checkPropValue has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function checkPropValue(node) {
      if (isArrayIndex(node)) {
        // key={bar}
        report(context, messages.noArrayIndex, 'noArrayIndex', {
          node,
    Severity: Minor
    Found in lib/rules/no-array-index-key.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

            if (node.type === 'CallExpression'
          && node.callee
          && node.callee.type === 'MemberExpression'
          && node.callee.object
          && isArrayIndex(node.callee.object)
      Severity: Critical
      Found in lib/rules/no-array-index-key.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

              if (node.type === 'CallExpression'
          && node.callee
          && node.callee.type === 'Identifier'
          && node.callee.name === 'String'
          && Array.isArray(node.arguments)
        Severity: Major
        Found in lib/rules/no-array-index-key.js - About 1 hr to fix

          Function isCreateCloneElement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function isCreateCloneElement(node, context) {
  if (!node) {
    return false;
  }
          Severity: Minor
          Found in lib/rules/no-array-index-key.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                return false;
          Severity: Major
          Found in lib/rules/no-array-index-key.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return null;
            Severity: Major
            Found in lib/rules/no-array-index-key.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return null;
              Severity: Major
              Found in lib/rules/no-array-index-key.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return params[indexParamPosition].name;
                Severity: Major
                Found in lib/rules/no-array-index-key.js - About 30 mins to fix

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                        if (node.type === 'CallExpression'
          && node.callee
          && node.callee.type === 'Identifier'
          && node.callee.name === 'String'
                  Severity: Major
                  Found in lib/rules/no-array-index-key.js and 2 other locations - About 40 mins to fix
                  lib/rules/iframe-missing-sandbox.js on lines 71..74
                  lib/util/jsx.js on lines 71..74

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 17 locations. Consider refactoring.
                  Open

                    meta: {
    docs: {
      description: 'Disallow usage of Array index in keys',
      category: 'Best Practices',
      recommended: false,
                  Severity: Major
                  Found in lib/rules/no-array-index-key.js and 16 other locations - About 35 mins to fix
                  lib/rules/jsx-no-comment-textnodes.js on lines 37..48
                  lib/rules/no-danger.js on lines 47..58
                  lib/rules/no-deprecated.js on lines 118..129
                  lib/rules/no-find-dom-node.js on lines 20..31
                  lib/rules/no-is-mounted.js on lines 20..31
                  lib/rules/no-namespace.js on lines 22..33
                  lib/rules/no-redundant-should-component-update.js on lines 21..32
                  lib/rules/no-render-return-value.js on lines 21..32
                  lib/rules/no-set-state.js on lines 23..34
                  lib/rules/no-this-in-sfc.js on lines 20..31
                  lib/rules/no-typos.js on lines 32..43
                  lib/rules/no-unused-class-component-methods.js on lines 102..111
                  lib/rules/no-unused-state.js on lines 81..92
                  lib/rules/prefer-exact-props.js on lines 24..33
                  lib/rules/react-in-jsx-scope.js on lines 22..33
                  lib/rules/require-render-return.js on lines 25..36

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 47.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status