Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star
lib/rules/no-typos.js

Summary

Maintainability
D
2 days
Test Coverage

Function create has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

  create: Components.detect((context, components, utils) => {
    let propTypesPackageName = null;
    let reactPackageName = null;

    function checkValidPropTypeQualifier(node) {
Severity: Minor
Found in lib/rules/no-typos.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 183 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create: Components.detect((context, components, utils) => {
    let propTypesPackageName = null;
    let reactPackageName = null;

    function checkValidPropTypeQualifier(node) {
Severity: Major
Found in lib/rules/no-typos.js - About 7 hrs to fix

    Function reportErrorIfLifecycleMethodCasingTypo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function reportErrorIfLifecycleMethodCasingTypo(node) {
      const key = node.key;
      let nodeKeyName = key.name;
      if (key.type === 'Literal') {
        nodeKeyName = key.value;
    Severity: Minor
    Found in lib/rules/no-typos.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (
          relatedComponent
            && (componentUtil.isES6Component(relatedComponent.node, context) || (
              relatedComponent.node.type !== 'ClassDeclaration' && utils.isReturningJSX(relatedComponent.node)))
            && (node.parent && node.parent.type === 'AssignmentExpression' && node.parent.right)
      Severity: Major
      Found in lib/rules/no-typos.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  if (node.specifiers.length >= 1) {
            const propTypesSpecifier = node.specifiers.find((specifier) => (
              specifier.imported && specifier.imported.name === 'PropTypes'
            ));
            if (propTypesSpecifier) {
        Severity: Major
        Found in lib/rules/no-typos.js and 1 other location - About 2 hrs to fix
        lib/rules/forbid-prop-types.js on lines 196..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 84.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 17 locations. Consider refactoring.
        Open

          meta: {
    docs: {
      description: 'Disallow common typos',
      category: 'Stylistic Issues',
      recommended: false,
        Severity: Major
        Found in lib/rules/no-typos.js and 16 other locations - About 35 mins to fix
        lib/rules/jsx-no-comment-textnodes.js on lines 38..49
        lib/rules/no-array-index-key.js on lines 46..57
        lib/rules/no-danger.js on lines 48..59
        lib/rules/no-deprecated.js on lines 118..129
        lib/rules/no-find-dom-node.js on lines 20..31
        lib/rules/no-is-mounted.js on lines 20..31
        lib/rules/no-namespace.js on lines 23..34
        lib/rules/no-redundant-should-component-update.js on lines 22..33
        lib/rules/no-render-return-value.js on lines 21..32
        lib/rules/no-set-state.js on lines 24..35
        lib/rules/no-this-in-sfc.js on lines 21..32
        lib/rules/no-unused-class-component-methods.js on lines 102..111
        lib/rules/no-unused-state.js on lines 81..92
        lib/rules/prefer-exact-props.js on lines 25..34
        lib/rules/react-in-jsx-scope.js on lines 23..34
        lib/rules/require-render-return.js on lines 26..37

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status