Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star
lib/rules/no-unused-state.js

Summary

Maintainability
F
6 days
Test Coverage

Function create has a Cognitive Complexity of 140 (exceeds 5 allowed). Consider refactoring.
Open

  create(context) {
    // Non-null when we are inside a React component ClassDeclaration and we have
    // not yet encountered any use of this.state which we have chosen not to
    // analyze. If we encounter any such usage (like this.state being spread as
    // JSX attributes), then this is again set to null.
Severity: Minor
Found in lib/rules/no-unused-state.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 343 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  create(context) {
    // Non-null when we are inside a React component ClassDeclaration and we have
    // not yet encountered any use of this.state which we have chosen not to
    // analyze. If we encounter any such usage (like this.state being spread as
    // JSX attributes), then this is again set to null.
Severity: Major
Found in lib/rules/no-unused-state.js - About 1 day to fix

    File no-unused-state.js has 403 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @fileoverview  Attempts to discover all state fields in a React component and
 * warn if any of them are never read.
 *
 * State field definitions are collected from `this.state = {}` assignments in
    Severity: Minor
    Found in lib/rules/no-unused-state.js - About 5 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if (
          parent
          && parent.type === 'MethodDefinition' && (
            (parent.static && parent.key.name === 'getDerivedStateFromProps')
            || classMethods.indexOf(parent.key.name) !== -1
      Severity: Critical
      Found in lib/rules/no-unused-state.js - About 1 hr to fix

        Function CallExpression has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              CallExpression(node) {
        if (!classInfo) {
          return;
        }
        Severity: Minor
        Found in lib/rules/no-unused-state.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                          if (name) {
                  classInfo.aliases.add(name);
                } else if (prop.value.type === 'ObjectPattern') {
                  handleStateDestructuring(prop.value);
                }
          Severity: Major
          Found in lib/rules/no-unused-state.js - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            function getName(node) {
  node = uncast(node);
  const type = node.type;

  if (type === 'Identifier') {
            Severity: Major
            Found in lib/rules/no-unused-state.js and 1 other location - About 4 hrs to fix
            lib/rules/no-unused-class-component-methods.js on lines 62..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 124.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 17 locations. Consider refactoring.
            Open

              meta: {
    docs: {
      description: 'Disallow definitions of unused state',
      category: 'Best Practices',
      recommended: false,
            Severity: Major
            Found in lib/rules/no-unused-state.js and 16 other locations - About 35 mins to fix
            lib/rules/jsx-no-comment-textnodes.js on lines 38..49
            lib/rules/no-array-index-key.js on lines 46..57
            lib/rules/no-danger.js on lines 48..59
            lib/rules/no-deprecated.js on lines 118..129
            lib/rules/no-find-dom-node.js on lines 20..31
            lib/rules/no-is-mounted.js on lines 20..31
            lib/rules/no-namespace.js on lines 23..34
            lib/rules/no-redundant-should-component-update.js on lines 22..33
            lib/rules/no-render-return-value.js on lines 21..32
            lib/rules/no-set-state.js on lines 24..35
            lib/rules/no-this-in-sfc.js on lines 21..32
            lib/rules/no-typos.js on lines 33..44
            lib/rules/no-unused-class-component-methods.js on lines 102..111
            lib/rules/prefer-exact-props.js on lines 25..34
            lib/rules/react-in-jsx-scope.js on lines 23..34
            lib/rules/require-render-return.js on lines 26..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            function uncast(node) {
  while (node.type === 'TypeCastExpression') {
    node = node.expression;
  }
  return node;
            Severity: Minor
            Found in lib/rules/no-unused-state.js and 1 other location - About 30 mins to fix
            lib/rules/no-unused-class-component-methods.js on lines 52..57

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status