Sign upLogin

yannickcr/eslint-plugin-react

View on GitHub
Star
lib/util/propTypesSort.js

Summary

Maintainability
D
1 day
Test Coverage

Function fixPropTypesSort has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function fixPropTypesSort(
  context,
  fixer,
  declarations,
  ignoreCase,
Severity: Minor
Found in lib/util/propTypesSort.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fixPropTypesSort has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function fixPropTypesSort(
  context,
  fixer,
  declarations,
  ignoreCase,
Severity: Major
Found in lib/util/propTypesSort.js - About 2 hrs to fix

    Function sortInSource has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function sortInSource(allNodes, source) {
    const originalSource = source;
    const sourceCode = getSourceCode(context);
    for (let i = 0; i < allNodes.length; i++) {
      const node = allNodes[i];
    Severity: Major
    Found in lib/util/propTypesSort.js - About 2 hrs to fix

      Function sorter has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      function sorter(a, b, context, ignoreCase, requiredFirst, callbacksLast, noSortAlphabetically) {
  const aKey = String(astUtil.getKeyValue(context, a));
  const bKey = String(astUtil.getKeyValue(context, b));

  if (requiredFirst) {
      Severity: Minor
      Found in lib/util/propTypesSort.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function sorter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function sorter(a, b, context, ignoreCase, requiredFirst, callbacksLast, noSortAlphabetically) {
  const aKey = String(astUtil.getKeyValue(context, a));
  const bKey = String(astUtil.getKeyValue(context, b));

  if (requiredFirst) {
      Severity: Minor
      Found in lib/util/propTypesSort.js - About 1 hr to fix

        Function fixPropTypesSort has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          context,
  fixer,
  declarations,
  ignoreCase,
  requiredFirst,
        Severity: Major
        Found in lib/util/propTypesSort.js - About 1 hr to fix

          Function sorter has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function sorter(a, b, context, ignoreCase, requiredFirst, callbacksLast, noSortAlphabetically) {
          Severity: Major
          Found in lib/util/propTypesSort.js - About 50 mins to fix

            Avoid too many return statements within this function.
            Open

                  return -1;
            Severity: Major
            Found in lib/util/propTypesSort.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return 0;
              Severity: Major
              Found in lib/util/propTypesSort.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return 1;
                Severity: Major
                Found in lib/util/propTypesSort.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return aKey.localeCompare(bKey);
                  Severity: Major
                  Found in lib/util/propTypesSort.js - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    function isShapeProp(node) {
  return Boolean(
    node && node.callee && node.callee.property && node.callee.property.name === 'shape'
  );
}
                    Severity: Minor
                    Found in lib/util/propTypesSort.js and 1 other location - About 50 mins to fix
                    lib/rules/sort-prop-types.js on lines 50..54

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status