Sign upLogin

yannickcr/node-bittorrent-sync

View on GitHub
Star

Showing 4 of 4 total issues

Function _apiCallback has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

BTSync.prototype._apiCallback = function(callback, timerStart, err, res, data) {
  // Check the err object
  if (err) {
    return callback(err, data);
  }
Severity: Minor
Found in lib/bittorrent-sync.js - About 1 hr to fix

    Function _apiCallback has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    BTSync.prototype._apiCallback = function(callback, timerStart, err, res, data) {
    Severity: Minor
    Found in lib/bittorrent-sync.js - About 35 mins to fix

      Function _apiCallback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      BTSync.prototype._apiCallback = function(callback, timerStart, err, res, data) {
  // Check the err object
  if (err) {
    return callback(err, data);
  }
      Severity: Minor
      Found in lib/bittorrent-sync.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

        return callback(null, data);
      Severity: Major
      Found in lib/bittorrent-sync.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language