yashketkar/video-player

View on GitHub

Showing 108 of 144 total issues

Avoid too many return statements within this method.
Open

          return;
Severity: Major
Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                            return false;
    Severity: Major
    Found in vitamio/src/io/vov/vitamio/utils/Base64.java - About 30 mins to fix

      Method stayAwake has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        @SuppressLint("Wakelock")
        private void stayAwake(boolean awake) {
          if (mWakeLock != null) {
            if (awake && !mWakeLock.isHeld()) {
              mWakeLock.acquire();
      Severity: Minor
      Found in vitamio/src/io/vov/vitamio/MediaPlayer.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method requestPermissions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private void requestPermissions(final Activity thisActivity, View videosFragmentView) {
              if (ContextCompat.checkSelfPermission(thisActivity,
                      Manifest.permission.READ_EXTERNAL_STORAGE)
                      != PackageManager.PERMISSION_GRANTED) {
                  // Should we show an explanation?
      Severity: Minor
      Found in app/src/main/java/com/yashketkar/ykplayer/VideosFragment.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method scanDirectories has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        public void scanDirectories(String[] directories) {
          try {
            long start = System.currentTimeMillis();
            prescan(null);
            long prescan = System.currentTimeMillis();
      Severity: Minor
      Found in vitamio/src/io/vov/vitamio/MediaScanner.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method onCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
          public void onCreate(Bundle savedInstanceState) {
              super.onCreate(savedInstanceState);
      
              adapter = new LiveTVAdapter(getActivity(), tvList);
      Severity: Minor
      Found in app/src/main/java/com/yashketkar/ykplayer/LiveTVFragment.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getUniqueFileName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String getUniqueFileName(String name, String id) {
              StringBuilder sb = new StringBuilder();
              for (Character c : name.toCharArray()) {
                  if (FILE_NAME_RESERVED.indexOf(c) == -1) {
                      sb.append(c);
      Severity: Minor
      Found in vitamio/src/io/vov/vitamio/utils/FileUtils.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method join has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String join(Iterable<? extends Object> elements, CharSequence separator) {
              StringBuilder builder = new StringBuilder();
      
              if (elements != null) {
                  Iterator<? extends Object> iter = elements.iterator();
      Severity: Minor
      Found in vitamio/src/io/vov/vitamio/utils/StringUtils.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language