yast/yast-installation

View on GitHub

Showing 19 of 173 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def AdjustDisabledModules
      if InstData.wizardsteps_disabled_modules.nil?
        Builtins.y2error("Disabled modules file not defined")
        return
      end
Severity: Major
Found in src/include/installation/inst_inc_second.rb and 1 other location - About 1 hr to fix
src/include/installation/inst_inc_second.rb on lines 99..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def AdjustDisabledProposals
      if InstData.wizardsteps_disabled_proposals.nil?
        Builtins.y2error("Disabled proposals file not defined")
        return
      end
Severity: Major
Found in src/include/installation/inst_inc_second.rb and 1 other location - About 1 hr to fix
src/include/installation/inst_inc_second.rb on lines 60..96

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def copy_nvme
      # Only in install, as update should keep its config
      return unless Mode.installation

      # Copy NVMe config files (bsc #1172853)
Severity: Minor
Found in src/lib/installation/clients/copy_files_finish.rb and 1 other location - About 50 mins to fix
src/lib/installation/clients/copy_files_finish.rb on lines 247..259

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def copy_multipath
      # Only in install, as update should keep its old config
      return unless Mode.installation

      # Copy multipath stuff (bnc#885628, bsc#1133045)
Severity: Minor
Found in src/lib/installation/clients/copy_files_finish.rb and 1 other location - About 50 mins to fix
src/lib/installation/clients/copy_files_finish.rb on lines 270..282

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/save_config_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/switch_scr_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/ssh_settings_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/driver_update2_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/kernel_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/network_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/proxy_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/x11_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/installation_settings_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/save_hw_status_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/ldconfig_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/yast_inf_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update1_finish.rb on lines 44..51
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 13 locations. Consider refactoring.
Open

      if Ops.greater_than(Builtins.size(WFM.Args), 0) &&
          Ops.is_string?(WFM.Args(0))
        @func = Convert.to_string(WFM.Args(0))
        if Ops.greater_than(Builtins.size(WFM.Args), 1) &&
            Ops.is_map?(WFM.Args(1))
Severity: Major
Found in src/lib/installation/clients/driver_update1_finish.rb and 12 other locations - About 45 mins to fix
src/lib/installation/clients/driver_update2_finish.rb on lines 44..51
src/lib/installation/clients/installation_settings_finish.rb on lines 42..49
src/lib/installation/clients/kernel_finish.rb on lines 45..52
src/lib/installation/clients/ldconfig_finish.rb on lines 41..48
src/lib/installation/clients/network_finish.rb on lines 43..50
src/lib/installation/clients/proxy_finish.rb on lines 46..53
src/lib/installation/clients/save_config_finish.rb on lines 63..70
src/lib/installation/clients/save_hw_status_finish.rb on lines 47..54
src/lib/installation/clients/ssh_settings_finish.rb on lines 45..52
src/lib/installation/clients/switch_scr_finish.rb on lines 46..53
src/lib/installation/clients/x11_finish.rb on lines 46..53
src/lib/installation/clients/yast_inf_finish.rb on lines 53..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if WFM.Execute(path(".local.bash"), copyCmd) == 0
          @GET_error = ""
          ok = true
        else
          # autoyast tried to copy a file via NFS which failed
Severity: Minor
Found in src/lib/transfer/file_from_url.rb and 1 other location - About 40 mins to fix
src/lib/transfer/file_from_url.rb on lines 376..387

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if WFM.Execute(path(".local.bash"), copyCmd) == 0
          @GET_error = ""
          ok = true
        else
          # autoyast tried to copy a file via NFS which failed
Severity: Minor
Found in src/lib/transfer/file_from_url.rb and 1 other location - About 40 mins to fix
src/lib/transfer/file_from_url.rb on lines 420..431

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language