Sign upLogin

yegor256/sixnines

View on GitHub
Star

Showing 7 of 7 total issues

File sixnines.rb has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'haml'
require 'haml/template/options'
require 'sinatra'
require 'sinatra/cookies'
require 'sass'
Severity: Minor
Found in sixnines.rb - About 3 hrs to fix

    Method ping has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def ping(count, proxies = [''])
    start = Time.now
    h = to_h
    code, body, log = ProxiedResource.new(
      CountedResource.new(
    Severity: Major
    Found in objects/endpoint.rb - About 2 hrs to fix

      Method take has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def take
    a = [500, '', 'There are no proxies']
    @proxies.each do |p|
      host, port = p.split(':')
      begin
      Severity: Minor
      Found in objects/proxied_resource.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ping has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def ping(count, proxies = [''])
    start = Time.now
    h = to_h
    code, body, log = ProxiedResource.new(
      CountedResource.new(
      Severity: Minor
      Found in objects/endpoint.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method favicon has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def favicon(body)
    xml = Nokogiri::HTML(body)
    links = xml.xpath('/html/head/link[@rel="shortcut icon"]/@href')
    uri = to_h[:uri]
    raise "Favicon URI can't be nil in the endpoint" if uri.nil?
      Severity: Minor
      Found in objects/endpoint.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method png has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def png
    Dir.mktmpdir do |dir|
      uri = @endpoint.to_h[:favicon]
      raise 'Favicon URI is nil' if uri.nil?
      http = Net::HTTP.new(uri.host, uri.port)
      Severity: Minor
      Found in objects/endpoint/ep_favicon.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method png has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def png
    Dir.mktmpdir do |dir|
      uri = @endpoint.to_h[:favicon]
      raise 'Favicon URI is nil' if uri.nil?
      http = Net::HTTP.new(uri.host, uri.port)
      Severity: Minor
      Found in objects/endpoint/ep_favicon.rb - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language