Sign upLogin

yippie-io/iUPB

View on GitHub
Star
public/scripts/add2home.js

Summary

Maintainability
F
4 days
Test Coverage

Function addToHome has a Cognitive Complexity of 112 (exceeds 5 allowed). Consider refactoring.
Open

var addToHome = (function (w) {
    var nav = w.navigator,
        isIDevice = 'platform' in nav && (/iphone|ipod|ipad/gi).test(nav.platform),
        isIPad,
        isRetina,
Severity: Minor
Found in public/scripts/add2home.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addToHome has 267 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var addToHome = (function (w) {
    var nav = w.navigator,
        isIDevice = 'platform' in nav && (/iphone|ipod|ipad/gi).test(nav.platform),
        isIPad,
        isRetina,
Severity: Major
Found in public/scripts/add2home.js - About 1 day to fix

    File add2home.js has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * Add to Homescreen v2.0 ~ Copyright (c) 2012 Matteo Spinelli, http://cubiq.org
 * Released under MIT license, http://cubiq.org/license
 */
var addToHome = (function (w) {
    Severity: Minor
    Found in public/scripts/add2home.js - About 2 hrs to fix

      Function show has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function show () {
        var duration,
            iPadXShift = 160;

        // Set the initial position
      Severity: Major
      Found in public/scripts/add2home.js - About 2 hrs to fix

        Function loaded has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function loaded () {
        w.removeEventListener('load', loaded, false);

        if ( !overrideChecks && (!isSafari || !isExpired || isSessionActive || isStandalone || !isReturningVisitor) ) return;
        Severity: Minor
        Found in public/scripts/add2home.js - About 1 hr to fix

          Function close has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function close () {
        clearInterval( positionInterval );
        clearTimeout( closeTimeout );
        closeTimeout = null;
          Severity: Minor
          Found in public/scripts/add2home.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                    if ( !overrideChecks && (!isSafari || !isExpired || isSessionActive || isStandalone || !isReturningVisitor) ) return;
            Severity: Major
            Found in public/scripts/add2home.js - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          posX = isIPad ? w.scrollX - startX : w.scrollX + Math.round((w.innerWidth - balloon.offsetWidth) / 2) - startX;
              Severity: Minor
              Found in public/scripts/add2home.js and 1 other location - About 50 mins to fix
              public/scripts/add2home.js on lines 252..252

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          posX = isIPad ? w.scrollX - startX : w.scrollX + Math.round((w.innerWidth - balloon.offsetWidth)/2) - startX;
              Severity: Minor
              Found in public/scripts/add2home.js and 1 other location - About 50 mins to fix
              public/scripts/add2home.js on lines 316..316

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status