Sign upLogin

ynakajima/node-spike-api

View on GitHub
Star

Showing 3 of 7 total issues

Function postToken has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

SpikeAPI.prototype.postToken = function(cardData, callback) {
  cardData = _.assign({
    'card[number]': 4444333322221111, // Number of credit card
    'card[exp_month]': 1, // Expire month of credit card
    'card[exp_year]': 2020, // Expire year of credit card
Severity: Minor
Found in lib/spike-api.js - About 1 hr to fix

    Function postCharge has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    SpikeAPI.prototype.postCharge = function(chargeData, callback) {
  chargeData = _.assign({
    currency: '', // Currency billing amount. ['USD'|'JPY']
    amount: 0, // Amount of the billing.
    card: '', // Token that has been acquired in SPIKE Checkout.
    Severity: Minor
    Found in lib/spike-api.js - About 1 hr to fix

      Function _validateArgs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function _validateArgs(argTypes, args, minArgs) {
  var isInvalid = false;
  minArgs = _.isNumber(minArgs) ? minArgs : argTypes.length;

  if (args.length < minArgs) {
      Severity: Minor
      Found in lib/spike-api.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language