Sign upLogin

yoctore/yocto-orika

View on GitHub
Star
src/api/modules/orkaisse/factory.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function prepare has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

OrkaisseFactory.prototype.prepare = function (shop, transaction, client, receipt, items, vouchers) {
Severity: Minor
Found in src/api/modules/orkaisse/factory.js - About 45 mins to fix

    Function order has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    OrkaisseFactory.prototype.order = function (shop, transaction, client, items, vouchers) {
    Severity: Minor
    Found in src/api/modules/orkaisse/factory.js - About 35 mins to fix

      Function paid has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      OrkaisseFactory.prototype.paid = function (shop, transaction, receipt, ttc, payments) {
      Severity: Minor
      Found in src/api/modules/orkaisse/factory.js - About 35 mins to fix

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        module.exports = function (l) {
  // is a valid logger ?
  if (_.isUndefined(l) || _.isNull(l)) {
    // warning message
    logger.warning([ '[ YoctoOrika.OrkaisseFactory.constructor ] -',
        Severity: Major
        Found in src/api/modules/orkaisse/factory.js and 7 other locations - About 2 hrs to fix
        src/api/core/request.js on lines 122..134
        src/api/modules/core.js on lines 174..186
        src/api/modules/orkaisse/index.js on lines 170..182
        src/api/modules/orkaisse/schema.js on lines 261..273
        src/api/modules/orkarte/factory.js on lines 30..42
        src/api/modules/orkarte/index.js on lines 144..156
        src/api/modules/orkarte/schema.js on lines 259..271

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 94.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status