Sign upLogin

yoctore/yocto-utils

View on GitHub
Star
src/modules/date/elapsed/index.js

Summary

Maintainability
D
3 days
Test Coverage

Function calculDifference has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  function (actualDate, limitDate, difference, firstPassage) {
  // Find a valid day from the actualDate
    var validDate = this.findNextValidDay(actualDate);

    // Check if the validDate is not BetweenOpenPlanning & if isBefore the limitDate
Severity: Minor
Found in src/modules/date/elapsed/index.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ElapsedTime.prototype.isBankHoliday = function (value) {
  // Is a valid moment date ?
  if (!moment.isMoment(value)) {
    throw 'Given value is not a valid moment date in isBankHoliday';
  }
Severity: Major
Found in src/modules/date/elapsed/index.js and 1 other location - About 4 hrs to fix
src/modules/date/elapsed/index.js on lines 88..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ElapsedTime.prototype.isNoWorkingDay = function (value) {
  // Is a valid moment date ?
  if (!moment.isMoment(value)) {
    throw 'Given value is not a valid moment date in isNotWorkingDay';
  }
Severity: Major
Found in src/modules/date/elapsed/index.js and 1 other location - About 4 hrs to fix
src/modules/date/elapsed/index.js on lines 63..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 134.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  var end = moment(b).hours(this.config.scheduleClose.hours)
    .minutes(this.config.scheduleClose.minutes)
    .seconds(this.config.scheduleClose.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 4 other locations - About 2 hrs to fix
src/modules/date/elapsed/index.js on lines 202..204
src/modules/date/elapsed/index.js on lines 242..244
src/modules/date/elapsed/index.js on lines 276..278
src/modules/date/elapsed/index.js on lines 281..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  var begin = moment(b).hours(this.config.scheduleOpen.hours)
    .minutes(this.config.scheduleOpen.minutes)
    .seconds(this.config.scheduleOpen.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 4 other locations - About 2 hrs to fix
src/modules/date/elapsed/index.js on lines 202..204
src/modules/date/elapsed/index.js on lines 207..209
src/modules/date/elapsed/index.js on lines 242..244
src/modules/date/elapsed/index.js on lines 281..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  var endDay = moment(date).hours(this.config.scheduleClose.hours)
    .minutes(this.config.scheduleClose.minutes)
    .seconds(this.config.scheduleClose.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 4 other locations - About 2 hrs to fix
src/modules/date/elapsed/index.js on lines 202..204
src/modules/date/elapsed/index.js on lines 207..209
src/modules/date/elapsed/index.js on lines 276..278
src/modules/date/elapsed/index.js on lines 281..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  var end = moment(b).hours(this.config.scheduleClose.hours)
    .minutes(this.config.scheduleClose.minutes)
    .seconds(this.config.scheduleClose.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 4 other locations - About 2 hrs to fix
src/modules/date/elapsed/index.js on lines 202..204
src/modules/date/elapsed/index.js on lines 207..209
src/modules/date/elapsed/index.js on lines 242..244
src/modules/date/elapsed/index.js on lines 276..278

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  var begin = moment(b).hours(this.config.scheduleOpen.hours)
    .minutes(this.config.scheduleOpen.minutes)
    .seconds(this.config.scheduleOpen.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 4 other locations - About 2 hrs to fix
src/modules/date/elapsed/index.js on lines 207..209
src/modules/date/elapsed/index.js on lines 242..244
src/modules/date/elapsed/index.js on lines 276..278
src/modules/date/elapsed/index.js on lines 281..283

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return moment(b)
      .add(1, 'd')
      .hours(this.config.scheduleOpen.hours)
      .minutes(this.config.scheduleOpen.minutes)
      .seconds(this.config.scheduleOpen.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 1 other location - About 1 hr to fix
src/modules/date/elapsed/index.js on lines 252..256

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var newDate = moment(date)
      .add(1, 'd')
      .hours(this.config.scheduleOpen.hours)
      .minutes(this.config.scheduleOpen.minutes)
      .seconds(this.config.scheduleOpen.seconds);
Severity: Major
Found in src/modules/date/elapsed/index.js and 1 other location - About 1 hr to fix
src/modules/date/elapsed/index.js on lines 295..299

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 74.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status