yoichiro/chromeos-filesystem-dropbox

View on GitHub

Showing 23 of 33 total issues

File dropbox_client.js has 610 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const AUTH_URL = 'https://www.dropbox.com/oauth2/authorize' +
    '?response_type=token&client_id=u4emlzpeiilp7n0' +
    '&force_reapprove=true' +
Severity: Major
Found in src/scripts/dropbox_client.js - About 1 day to fix

    File dropbox_fs.js has 460 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';
    
    // Constants
    
    const FILE_SYSTEM_ID = 'dropboxfs';
    Severity: Minor
    Found in src/scripts/dropbox_fs.js - About 7 hrs to fix

      DropboxFS has 41 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class DropboxFS {
      
          // Constructor
      
          constructor() {
      Severity: Minor
      Found in src/scripts/dropbox_fs.js - About 5 hrs to fix

        DropboxClient has 37 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class DropboxClient {
        
            // Constructor
        
            constructor(dropboxFS) {
        Severity: Minor
        Found in src/scripts/dropbox_client.js - About 4 hrs to fix

          Function sendContents has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              sendContents(options, successCallback, errorCallback) {
                  if (!options.hasMore) {
                      if (options.needCommit) {
                          const data1 = this.jsonStringify({
                              cursor: {
          Severity: Major
          Found in src/scripts/dropbox_client.js - About 2 hrs to fix

            Function assignEventHandlers has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                assignEventHandlers() {
                    console.log('Start: assignEventHandlers');
                    chrome.alarms.onAlarm.addListener(alarm => {
                        if (alarm.name === 'dropbox_alarm') {
                            this.onAlarm(alarm);
            Severity: Major
            Found in src/scripts/dropbox_fs.js - About 2 hrs to fix

              Function background has 51 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const background = () => {
                  if (!chrome.fileSystemProvider) {
                      console.log('There is no chrome.fileSystemProvider API. See you on ChromeOS!');
                      return;
                  }
              Severity: Major
              Found in src/scripts/background.js - About 2 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                            if (window.FormData &&
                                ((options.dataType && (options.dataType === 'binary')) ||
                                 (options.data && ((window.ArrayBuffer && options.data instanceof ArrayBuffer) ||
                                                   (window.Blob && options.data instanceof Blob))))) {
                                return {
                Severity: Critical
                Found in src/scripts/dropbox_client.js - About 2 hrs to fix

                  Function truncate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      truncate(filePath, length, successCallback, errorCallback) {
                          const data = this.jsonStringify({
                              path: filePath
                          });
                          new HttpFetcher(this, 'truncate', {
                  Severity: Minor
                  Found in src/scripts/dropbox_client.js - About 1 hr to fix

                    Function getMetadata has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getMetadata(path, successCallback, errorCallback) {
                            if (path === '/') {
                                successCallback({
                                    isDirectory: true,
                                    name: '',
                    Severity: Minor
                    Found in src/scripts/dropbox_client.js - About 1 hr to fix

                      Function mount has 42 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          mount(successCallback, errorCallback) {
                              const dropboxClient = new DropboxClient(this);
                              dropboxClient.authorize(() => {
                                  dropboxClient.getUserInfo((userInfo) => {
                                      console.log(userInfo);
                      Severity: Minor
                      Found in src/scripts/dropbox_fs.js - About 1 hr to fix

                        Function watchDirectory has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            watchDirectory(fileSystemId, dropboxClient, entryPath) {
                                this.useWatcher(use => {
                                    if (!use) {
                                        return;
                                    }
                        Severity: Minor
                        Found in src/scripts/dropbox_fs.js - About 1 hr to fix

                          Function get has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              get(entryPath) {
                                  if (entryPath === '/') {
                                      return {
                                          needFetch: true,
                                          exists: true
                          Severity: Minor
                          Found in src/scripts/metadata_cache.js - About 1 hr to fix

                            Function get has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                            Open

                                get(entryPath) {
                                    if (entryPath === '/') {
                                        return {
                                            needFetch: true,
                                            exists: true
                            Severity: Minor
                            Found in src/scripts/metadata_cache.js - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function closeFile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                closeFile(filePath, openRequestId, mode, successCallback, errorCallback) {
                                    const writeRequest = this.writeRequestMap[openRequestId];
                                    if (writeRequest && mode === 'WRITE') {
                                        const uploadId = writeRequest.uploadId;
                                        if (uploadId) {
                            Severity: Minor
                            Found in src/scripts/dropbox_client.js - About 1 hr to fix

                              Function onClickedBtnMount has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  onClickedBtnMount(evt) {
                                      const btnMount = document.querySelector('#btnMount');
                                      evt.preventDefault();
                                      btnMount.setAttribute('disabled', 'true');
                                      $.toast({
                              Severity: Minor
                              Found in src/scripts/window.js - About 1 hr to fix

                                Function authorize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    authorize(successCallback, errorCallback) {
                                        this.access_token_ = null;
                                        chrome.identity.launchWebAuthFlow({
                                            'url': AUTH_URL,
                                            'interactive': true
                                Severity: Minor
                                Found in src/scripts/dropbox_client.js - About 1 hr to fix

                                  Function createEventHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      createEventHandler(callback) {
                                          return (options, successCallback, errorCallback) => {
                                              const fileSystemId = options.fileSystemId;
                                              const dropboxClient = this.getDropboxClient(fileSystemId);
                                              if (!dropboxClient) {
                                  Severity: Minor
                                  Found in src/scripts/dropbox_fs.js - About 1 hr to fix

                                    Function handleError has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        handleError(error, _textStatus, _errorThrown) {
                                            const status = Number(error.status);
                                            if (status === 404 || status === 409) {
                                                console.debug(error);
                                                this.errorCallback_('NOT_FOUND');
                                    Severity: Minor
                                    Found in src/scripts/http_fetcher.js - About 1 hr to fix

                                      Function initializeJQueryAjaxBinaryHandler has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          initializeJQueryAjaxBinaryHandler() {
                                              $.ajaxTransport('+binary', (options, originalOptions, jqXHR) => {
                                                  if (window.FormData &&
                                                      ((options.dataType && (options.dataType === 'binary')) ||
                                                       (options.data && ((window.ArrayBuffer && options.data instanceof ArrayBuffer) ||
                                      Severity: Minor
                                      Found in src/scripts/dropbox_client.js - About 1 hr to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language