Sign upLogin

yoichiro/chromeos-filesystem-dropbox

View on GitHub
Star
src/scripts/dropbox_client.js

Summary

Maintainability
F
4 days
Test Coverage

File dropbox_client.js has 610 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const AUTH_URL = 'https://www.dropbox.com/oauth2/authorize' +
    '?response_type=token&client_id=u4emlzpeiilp7n0' +
    '&force_reapprove=true' +
Severity: Major
Found in src/scripts/dropbox_client.js - About 1 day to fix

    DropboxClient has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DropboxClient {

    // Constructor

    constructor(dropboxFS) {
    Severity: Minor
    Found in src/scripts/dropbox_client.js - About 4 hrs to fix

      Function sendContents has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          sendContents(options, successCallback, errorCallback) {
        if (!options.hasMore) {
            if (options.needCommit) {
                const data1 = this.jsonStringify({
                    cursor: {
      Severity: Major
      Found in src/scripts/dropbox_client.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                    if (window.FormData &&
                ((options.dataType && (options.dataType === 'binary')) ||
                 (options.data && ((window.ArrayBuffer && options.data instanceof ArrayBuffer) ||
                                   (window.Blob && options.data instanceof Blob))))) {
                return {
        Severity: Critical
        Found in src/scripts/dropbox_client.js - About 2 hrs to fix

          Function truncate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              truncate(filePath, length, successCallback, errorCallback) {
        const data = this.jsonStringify({
            path: filePath
        });
        new HttpFetcher(this, 'truncate', {
          Severity: Minor
          Found in src/scripts/dropbox_client.js - About 1 hr to fix

            Function getMetadata has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getMetadata(path, successCallback, errorCallback) {
        if (path === '/') {
            successCallback({
                isDirectory: true,
                name: '',
            Severity: Minor
            Found in src/scripts/dropbox_client.js - About 1 hr to fix

              Function closeFile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  closeFile(filePath, openRequestId, mode, successCallback, errorCallback) {
        const writeRequest = this.writeRequestMap[openRequestId];
        if (writeRequest && mode === 'WRITE') {
            const uploadId = writeRequest.uploadId;
            if (uploadId) {
              Severity: Minor
              Found in src/scripts/dropbox_client.js - About 1 hr to fix

                Function authorize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    authorize(successCallback, errorCallback) {
        this.access_token_ = null;
        chrome.identity.launchWebAuthFlow({
            'url': AUTH_URL,
            'interactive': true
                Severity: Minor
                Found in src/scripts/dropbox_client.js - About 1 hr to fix

                  Function initializeJQueryAjaxBinaryHandler has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      initializeJQueryAjaxBinaryHandler() {
        $.ajaxTransport('+binary', (options, originalOptions, jqXHR) => {
            if (window.FormData &&
                ((options.dataType && (options.dataType === 'binary')) ||
                 (options.data && ((window.ArrayBuffer && options.data instanceof ArrayBuffer) ||
                  Severity: Minor
                  Found in src/scripts/dropbox_client.js - About 1 hr to fix

                    Function createEntryMetadatas has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        createEntryMetadatas(contents, index, entryMetadatas, successCallback, errorCallback) {
        if (contents.length === index) {
            successCallback(entryMetadatas);
        } else {
            const content = contents[index];
                    Severity: Minor
                    Found in src/scripts/dropbox_client.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function closeFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        closeFile(filePath, openRequestId, mode, successCallback, errorCallback) {
        const writeRequest = this.writeRequestMap[openRequestId];
        if (writeRequest && mode === 'WRITE') {
            const uploadId = writeRequest.uploadId;
            if (uploadId) {
                    Severity: Minor
                    Found in src/scripts/dropbox_client.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            new HttpFetcher(this, 'createOrDeleteEntry', {
            type: 'POST',
            url: 'https://api.dropboxapi.com/2/files/' + operation,
            headers: {
                'Authorization': 'Bearer ' + this.access_token_,
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 2 hrs to fix
                    src/scripts/dropbox_client.js on lines 468..479

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            new HttpFetcher(this, 'copyOrMoveEntry', {
            type: 'POST',
            url: 'https://api.dropboxapi.com/2/files/' + operation,
            headers: {
                'Authorization': 'Bearer ' + this.access_token_,
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 2 hrs to fix
                    src/scripts/dropbox_client.js on lines 549..560

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 80.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                const entryMetadata = {
                isDirectory: content['.tag'] === 'folder',
                name: content.name,
                size: content.size || 0,
                modificationTime: content.server_modified ? new Date(content.server_modified) : new Date()
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 1 hr to fix
                    src/scripts/dropbox_client.js on lines 129..134

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 69.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                const entryMetadata = {
                isDirectory: result['.tag'] === 'folder',
                name: result.name,
                size: result.size || 0,
                modificationTime: result.server_modified ? new Date(result.server_modified) : new Date()
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 1 hr to fix
                    src/scripts/dropbox_client.js on lines 578..583

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 69.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            new HttpFetcher(this, 'createFile', {
            type: 'POST',
            url: 'https://content.dropboxapi.com/2/files/upload',
            headers: {
                'Authorization': 'Bearer ' + this.access_token_,
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 1 hr to fix
                    src/scripts/dropbox_client.js on lines 372..383

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            new HttpFetcher(this, 'startUploadSession', {
            type: 'POST',
            url: 'https://content.dropboxapi.com/2/files/upload_session/start',
            headers: {
                'Authorization': 'Bearer ' + this.access_token_,
                    Severity: Major
                    Found in src/scripts/dropbox_client.js and 1 other location - About 1 hr to fix
                    src/scripts/dropbox_client.js on lines 258..269

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 59.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status