yoichiro/chromeos-filesystem-dropbox

View on GitHub
src/scripts/dropbox_fs.js

Summary

Maintainability
D
2 days
Test Coverage

File dropbox_fs.js has 460 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

// Constants

const FILE_SYSTEM_ID = 'dropboxfs';
Severity: Minor
Found in src/scripts/dropbox_fs.js - About 7 hrs to fix

    DropboxFS has 41 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DropboxFS {
    
        // Constructor
    
        constructor() {
    Severity: Minor
    Found in src/scripts/dropbox_fs.js - About 5 hrs to fix

      Function assignEventHandlers has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          assignEventHandlers() {
              console.log('Start: assignEventHandlers');
              chrome.alarms.onAlarm.addListener(alarm => {
                  if (alarm.name === 'dropbox_alarm') {
                      this.onAlarm(alarm);
      Severity: Major
      Found in src/scripts/dropbox_fs.js - About 2 hrs to fix

        Function mount has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            mount(successCallback, errorCallback) {
                const dropboxClient = new DropboxClient(this);
                dropboxClient.authorize(() => {
                    dropboxClient.getUserInfo((userInfo) => {
                        console.log(userInfo);
        Severity: Minor
        Found in src/scripts/dropbox_fs.js - About 1 hr to fix

          Function watchDirectory has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              watchDirectory(fileSystemId, dropboxClient, entryPath) {
                  this.useWatcher(use => {
                      if (!use) {
                          return;
                      }
          Severity: Minor
          Found in src/scripts/dropbox_fs.js - About 1 hr to fix

            Function createEventHandler has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                createEventHandler(callback) {
                    return (options, successCallback, errorCallback) => {
                        const fileSystemId = options.fileSystemId;
                        const dropboxClient = this.getDropboxClient(fileSystemId);
                        if (!dropboxClient) {
            Severity: Minor
            Found in src/scripts/dropbox_fs.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  onAddWatcherRequested(dropboxClient, options, successCallback, _errorCallback) {
                      const watchers = this.getWatchers(options.fileSystemId);
                      watchers.add(options.entryPath);
                      successCallback();
                  }
              Severity: Minor
              Found in src/scripts/dropbox_fs.js and 1 other location - About 50 mins to fix
              src/scripts/dropbox_fs.js on lines 184..188

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  onRemoveWatcherRequested(dropboxClient, options, successCallback, _errorCallback) {
                      const watchers = this.getWatchers(options.fileSystemId);
                      watchers.delete(options.entryPath);
                      successCallback();
                  }
              Severity: Minor
              Found in src/scripts/dropbox_fs.js and 1 other location - About 50 mins to fix
              src/scripts/dropbox_fs.js on lines 178..182

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status