Sign upLogin

yuku-t/myslog

View on GitHub
Star

Showing 4 of 4 total issues

Method parse_record has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_record(records)
    response = {}

    while (record = records.shift) != nil
Severity: Minor
Found in lib/myslog.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_record has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_record(records)
    response = {}

    while (record = records.shift) != nil
Severity: Minor
Found in lib/myslog.rb - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                if elem.include?(":") && !elems[i+1].include?(":")
              value = elems[i+1]
              case value
              when /^\d+$/
                value = value.to_i
    Severity: Major
    Found in lib/myslog.rb - About 45 mins to fix

      Method divide has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def divide(lines)
    records = []

    line = lines.shift
      Severity: Minor
      Found in lib/myslog.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language