zammad/zammad

View on GitHub
app/assets/javascripts/app/lib/base/jsonlint.js

Summary

Maintainability
F
1 wk
Test Coverage

Function jsonlint has a Cognitive Complexity of 174 (exceeds 5 allowed). Consider refactoring.
Open

var jsonlint = (function(){
var parser = {trace: function trace() { },
yy: {},
symbols_: {"error":2,"JSONString":3,"STRING":4,"JSONNumber":5,"NUMBER":6,"JSONNullLiteral":7,"NULL":8,"JSONBooleanLiteral":9,"TRUE":10,"FALSE":11,"JSONText":12,"JSONValue":13,"EOF":14,"JSONObject":15,"JSONArray":16,"{":17,"}":18,"JSONMemberList":19,"JSONMember":20,":":21,",":22,"[":23,"]":24,"JSONElementList":25,"$accept":0,"$end":1},
terminals_: {2:"error",4:"STRING",6:"NUMBER",8:"NULL",10:"TRUE",11:"FALSE",14:"EOF",17:"{",18:"}",21:":",22:",",23:"[",24:"]"},
Severity: Minor
Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jsonlint has 357 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var jsonlint = (function(){
var parser = {trace: function trace() { },
yy: {},
symbols_: {"error":2,"JSONString":3,"STRING":4,"JSONNumber":5,"NUMBER":6,"JSONNullLiteral":7,"NULL":8,"JSONBooleanLiteral":9,"TRUE":10,"FALSE":11,"JSONText":12,"JSONValue":13,"EOF":14,"JSONObject":15,"JSONArray":16,"{":17,"}":18,"JSONMemberList":19,"JSONMember":20,":":21,",":22,"[":23,"]":24,"JSONElementList":25,"$accept":0,"$end":1},
terminals_: {2:"error",4:"STRING",6:"NUMBER",8:"NULL",10:"TRUE",11:"FALSE",14:"EOF",17:"{",18:"}",21:":",22:",",23:"[",24:"]"},
Severity: Major
Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 1 day to fix

    Function lexer has 163 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var lexer = (function(){
    var lexer = ({EOF:1,
    parseError:function parseError(str, hash) {
            if (this.yy.parseError) {
                this.yy.parseError(str, hash);
    Severity: Major
    Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 6 hrs to fix

      Function parse has 137 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      parse: function parse(input) {
          var self = this,
              stack = [0],
              vstack = [null], // semantic value stack
              lstack = [], // location stack
      Severity: Major
      Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 5 hrs to fix

        File jsonlint.js has 377 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /* Jison generated parser */
        var jsonlint = (function(){
        var parser = {trace: function trace() { },
        yy: {},
        symbols_: {"error":2,"JSONString":3,"STRING":4,"JSONNumber":5,"NUMBER":6,"JSONNullLiteral":7,"NULL":8,"JSONBooleanLiteral":9,"TRUE":10,"FALSE":11,"JSONText":12,"JSONValue":13,"EOF":14,"JSONObject":15,"JSONArray":16,"{":17,"}":18,"JSONMemberList":19,"JSONMember":20,":":21,",":22,"[":23,"]":24,"JSONElementList":25,"$accept":0,"$end":1},
        Severity: Minor
        Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 5 hrs to fix

          Function next has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          next:function () {
                  if (this.done) {
                      return this.EOF;
                  }
                  if (!this._input) this.done = true;
          Severity: Minor
          Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 1 hr to fix

            Function anonymous has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            performAction: function anonymous(yytext,yyleng,yylineno,yy,yystate,$$,_$) {
            
            var $0 = $$.length - 1;
            switch (yystate) {
            case 1: // replace escaped characters with actual character
            Severity: Minor
            Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 1 hr to fix

              Function anonymous has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              lexer.performAction = function anonymous(yy,yy_,$avoiding_name_collisions,YY_START) {
              
              var YYSTATE=YY_START
              switch($avoiding_name_collisions) {
              case 0:/* skip whitespace */
              Severity: Minor
              Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 1 hr to fix

                Function performAction has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                performAction: function anonymous(yytext,yyleng,yylineno,yy,yystate,$$,_$) {
                Severity: Major
                Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 50 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                  for (p in table[state]) if (this.terminals_[p] && p > 2) {
                                      expected.push("'"+this.terminals_[p]+"'");
                                  }
                  Severity: Major
                  Found in app/assets/javascripts/app/lib/base/jsonlint.js - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    table: [{3:5,4:[1,12],5:6,6:[1,13],7:3,8:[1,9],9:4,10:[1,10],11:[1,11],12:1,13:2,15:7,16:8,17:[1,14],23:[1,15]},{1:[3]},{14:[1,16]},{14:[2,7],18:[2,7],22:[2,7],24:[2,7]},{14:[2,8],18:[2,8],22:[2,8],24:[2,8]},{14:[2,9],18:[2,9],22:[2,9],24:[2,9]},{14:[2,10],18:[2,10],22:[2,10],24:[2,10]},{14:[2,11],18:[2,11],22:[2,11],24:[2,11]},{14:[2,12],18:[2,12],22:[2,12],24:[2,12]},{14:[2,3],18:[2,3],22:[2,3],24:[2,3]},{14:[2,4],18:[2,4],22:[2,4],24:[2,4]},{14:[2,5],18:[2,5],22:[2,5],24:[2,5]},{14:[2,1],18:[2,1],21:[2,1],22:[2,1],24:[2,1]},{14:[2,2],18:[2,2],22:[2,2],24:[2,2]},{3:20,4:[1,12],18:[1,17],19:18,20:19},{3:5,4:[1,12],5:6,6:[1,13],7:3,8:[1,9],9:4,10:[1,10],11:[1,11],13:23,15:7,16:8,17:[1,14],23:[1,15],24:[1,21],25:22},{1:[2,6]},{14:[2,13],18:[2,13],22:[2,13],24:[2,13]},{18:[1,24],22:[1,25]},{18:[2,16],22:[2,16]},{21:[1,26]},{14:[2,18],18:[2,18],22:[2,18],24:[2,18]},{22:[1,28],24:[1,27]},{22:[2,20],24:[2,20]},{14:[2,14],18:[2,14],22:[2,14],24:[2,14]},{3:20,4:[1,12],20:29},{3:5,4:[1,12],5:6,6:[1,13],7:3,8:[1,9],9:4,10:[1,10],11:[1,11],13:30,15:7,16:8,17:[1,14],23:[1,15]},{14:[2,19],18:[2,19],22:[2,19],24:[2,19]},{3:5,4:[1,12],5:6,6:[1,13],7:3,8:[1,9],9:4,10:[1,10],11:[1,11],13:31,15:7,16:8,17:[1,14],23:[1,15]},{18:[2,17],22:[2,17]},{18:[2,15],22:[2,15]},{22:[2,21],24:[2,21]}],
                    Severity: Major
                    Found in app/assets/javascripts/app/lib/base/jsonlint.js and 1 other location - About 2 hrs to fix
                    app/assets/javascripts/app/lib/base/jsonlint.js on lines 52..52

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 93.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status