Sign upLogin

zammad/zammad

View on GitHub
Star
app/assets/javascripts/app/lib/base/ua-parser.js

Summary

Maintainability
D
2 days
Test Coverage

File ua-parser.js has 703 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/////////////////////////////////////////////////////////////////////////////////
/* UAParser.js v1.0.34
   Copyright © 2012-2021 Faisal Salman <f@faisalman.com>
   MIT License *//*
   Detect Browser, Engine, OS, CPU, and Device type/model from User-Agent data.
Severity: Major
Found in app/assets/javascripts/app/lib/base/ua-parser.js - About 1 day to fix

    Function UAParser has 81 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var UAParser = function (ua, extensions) {

      if (typeof ua === OBJ_TYPE) {
          extensions = ua;
          ua = undefined;
    Severity: Major
    Found in app/assets/javascripts/app/lib/base/ua-parser.js - About 3 hrs to fix

      Function rgxMapper has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var rgxMapper = function (ua, arrays) {

          var i = 0, j, k, p, q, matches, match;

          // loop through all regexes maps
      Severity: Minor
      Found in app/assets/javascripts/app/lib/base/ua-parser.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                  if (typeof q === OBJ_TYPE && q.length > 0) {
                              if (q.length === 2) {
                                  if (typeof q[1] == FUNC_TYPE) {
                                      // assign modified match
                                      this[q[0]] = q[1].call(this, match);
        Severity: Major
        Found in app/assets/javascripts/app/lib/base/ua-parser.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            var oldSafariMap = {
          '1.0'   : '/8',
          '1.2'   : '/1',
          '1.3'   : '/3',
          '2.0'   : '/412',
          Severity: Minor
          Found in app/assets/javascripts/app/lib/base/ua-parser.js and 1 other location - About 35 mins to fix
          app/assets/javascripts/app/lib/base/codemirror.js on lines 11068..11068

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status