Sign upLogin

zammad/zammad

View on GitHub
Star
app/assets/javascripts/app/lib/bootstrap/modal.js

Summary

Maintainability
B
6 hrs
Test Coverage

File modal.js has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* ========================================================================
 * Bootstrap: modal.js v3.4.1
 * https://getbootstrap.com/docs/3.4/javascript/#modals
 * ========================================================================
 * Copyright 2011-2019 Twitter, Inc.
Severity: Minor
Found in app/assets/javascripts/app/lib/bootstrap/modal.js - About 2 hrs to fix

    Function backdrop has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Modal.prototype.backdrop = function (callback) {
    var that = this
    var animate = this.$element.hasClass('fade') ? 'fade' : ''

    if (this.isShown && this.options.backdrop) {
    Severity: Minor
    Found in app/assets/javascripts/app/lib/bootstrap/modal.js - About 1 hr to fix

      Function show has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Modal.prototype.show = function (_relatedTarget) {
    var that = this
    var e = $.Event('show.bs.modal', { relatedTarget: _relatedTarget })

    this.$element.trigger(e)
      Severity: Minor
      Found in app/assets/javascripts/app/lib/bootstrap/modal.js - About 1 hr to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

          $.fn.modal.noConflict = function () {
    $.fn.modal = old
    return this
  }
        Severity: Major
        Found in app/assets/javascripts/app/lib/bootstrap/modal.js and 4 other locations - About 40 mins to fix
        app/assets/javascripts/app/lib/bootstrap/button.js on lines 102..105
        app/assets/javascripts/app/lib/bootstrap/collapse.js on lines 191..194
        app/assets/javascripts/app/lib/bootstrap/dropdown.js on lines 149..152
        app/assets/javascripts/app/lib/bootstrap/tab.js on lines 137..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status