zammad/zammad

View on GitHub
app/assets/javascripts/app/lib/core/underscore-1.8.3.js

Summary

Maintainability
F
5 days
Test Coverage

File underscore-1.8.3.js has 1071 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//     Underscore.js 1.8.3
//     http://underscorejs.org
//     (c) 2009-2015 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
//     Underscore may be freely distributed under the MIT license.

Severity: Major
Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 2 days to fix

    Function eq has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var eq = function(a, b, aStack, bStack) {
        // Identical objects are equal. `0 === -0`, but they aren't identical.
        // See the [Harmony `egal` proposal](http://wiki.ecmascript.org/doku.php?id=harmony:egal).
        if (a === b) return a !== 0 || 1 / a === 1 / b;
        // A strict comparison is necessary because `null == undefined`.
    Severity: Major
    Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 2 hrs to fix

      Function template has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _.template = function(text, settings, oldSettings) {
          if (!settings && oldSettings) settings = oldSettings;
          settings = _.defaults({}, settings, _.templateSettings);
      
          // Combine delimiters into one regular expression via alternation.
      Severity: Minor
      Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 1 hr to fix

        Function throttle has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _.throttle = function(func, wait, options) {
            var context, args, result;
            var timeout = null;
            var previous = 0;
            if (!options) options = {};
        Severity: Minor
        Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

                if (aCtor !== bCtor && !(_.isFunction(aCtor) && aCtor instanceof aCtor &&
                                         _.isFunction(bCtor) && bCtor instanceof bCtor)
                                    && ('constructor' in a && 'constructor' in b)) {
                  return false;
                }
          Severity: Major
          Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 1 hr to fix

            Function iterator has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function iterator(obj, iteratee, memo, keys, index, length) {
            Severity: Minor
            Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 45 mins to fix

              Function executeBound has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                var executeBound = function(sourceFunc, boundFunc, context, callingContext, args) {
              Severity: Minor
              Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 35 mins to fix

                Avoid too many return statements within this function.
                Open

                    return true;
                Severity: Major
                Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return false;
                  Severity: Major
                  Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          if (length !== b.length) return false;
                    Severity: Major
                    Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              if (!eq(a[length], b[length], aStack, bStack)) return false;
                      Severity: Major
                      Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return +a === 0 ? 1 / +a === 1 / b : +a === +b;
                        Severity: Major
                        Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                if (typeof a != 'object' || typeof b != 'object') return false;
                          Severity: Major
                          Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  if (_.keys(b).length !== length) return false;
                            Severity: Major
                            Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      if (!(_.has(b, key) && eq(a[key], b[key], aStack, bStack))) return false;
                              Severity: Major
                              Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      if (aStack[length] === a) return bStack[length] === b;
                                Severity: Major
                                Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js - About 30 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      if (iteratee == null && obj != null) {
                                        obj = isArrayLike(obj) ? obj : _.values(obj);
                                        for (var i = 0, length = obj.length; i < length; i++) {
                                          value = obj[i];
                                          if (value < result) {
                                  Severity: Major
                                  Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js and 1 other location - About 2 hrs to fix
                                  app/assets/javascripts/app/lib/core/underscore-1.8.3.js on lines 302..319

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 90.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      if (iteratee == null && obj != null) {
                                        obj = isArrayLike(obj) ? obj : _.values(obj);
                                        for (var i = 0, length = obj.length; i < length; i++) {
                                          value = obj[i];
                                          if (value > result) {
                                  Severity: Major
                                  Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js and 1 other location - About 2 hrs to fix
                                  app/assets/javascripts/app/lib/core/underscore-1.8.3.js on lines 327..344

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 90.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                    var _ = function(obj) {
                                      if (obj instanceof _) return obj;
                                      if (!(this instanceof _)) return new _(obj);
                                      this._wrapped = obj;
                                    };
                                  Severity: Minor
                                  Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js and 1 other location - About 50 mins to fix
                                  app/assets/javascripts/app/lib/base/exif.js on lines 7..11

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 51.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                    if (typeof exports !== 'undefined') {
                                      if (typeof module !== 'undefined' && module.exports) {
                                        exports = module.exports = _;
                                      }
                                      exports._ = _;
                                  Severity: Minor
                                  Found in app/assets/javascripts/app/lib/core/underscore-1.8.3.js and 1 other location - About 50 mins to fix
                                  app/assets/javascripts/app/lib/base/exif.js on lines 13..20

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 51.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  There are no issues that match your filters.

                                  Category
                                  Status