Sign upLogin

zemd/node-security-voters

View on GitHub
Star

Showing 6 of 8 total issues

Function exports has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (accessMap = {}) => {
  return (attr, subj, user) => {
    if (typeof attr !== "undefined" /*|| !(subj instanceof RoutePath)*/) {
      return ACCESS.ABSTAIN;
    }
Severity: Minor
Found in voters/access-map-voter.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isGranted has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.isGranted = (attr, subj, user, strategy = STRATEGIES.AFFIRMATIVE, cb) => {
  logger.debug(`Attr: ${attr}, subj: ${subj}, user: ${user}, strategy: ${strategy}`);

  // voters$ is an array of observables
  let voters$ = Rx.Observable.from(
Severity: Minor
Found in index.js - About 1 hr to fix

    Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = (accessMap = {}) => {
  return (attr, subj, user) => {
    if (typeof attr !== "undefined" /*|| !(subj instanceof RoutePath)*/) {
      return ACCESS.ABSTAIN;
    }
    Severity: Minor
    Found in voters/access-map-voter.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

          return ACCESS.ABSTAIN;
      Severity: Major
      Found in voters/access-map-voter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return accessLevel.call(null, user);
        Severity: Major
        Found in voters/access-map-voter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return ACCESS.DENIED;
          Severity: Major
          Found in voters/access-map-voter.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language