Sign upLogin

zendesk/biz

View on GitHub
Star

Showing 3 of 3 total issues

Method for has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def for(duration)
        return enum_for(:for, duration) unless block_given?

        remaining = duration
Severity: Minor
Found in lib/biz/timeline/abstract.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method day_class has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.day_class
        Class.new(self) do
          def before(time)
            periods(:before, time).first.end_time
          end
Severity: Minor
Found in lib/biz/calculation/for_duration.rb - About 1 hr to fix

    Method until has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def until(terminus)
        return enum_for(:until, terminus) unless block_given?

        periods
          .map { |period| period & comparison_period(period, terminus) }
    Severity: Minor
    Found in lib/biz/timeline/abstract.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language