Sign upLogin

zeusjs/widgets

View on GitHub
Star
test/spec/zs_dropdown.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it( 'should show the tick mark for clicked item', function () {
            var list = $( $( element ).children() ).find( 'ul' ),
                listOptions = list.find( 'li' );

            angular.forEach( listOptions, function ( item, i ) {
Severity: Major
Found in test/spec/zs_dropdown.js and 1 other location - About 6 hrs to fix
test/spec/zs_dropdown.js on lines 109..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it( 'should show the tick mark for clicked item', function () {
            var list = $( $( element ).children() ).find( 'ul' ),
                listOptions = list.find( 'li' );

            angular.forEach( listOptions, function ( item, i ) {
Severity: Major
Found in test/spec/zs_dropdown.js and 1 other location - About 6 hrs to fix
test/spec/zs_dropdown.js on lines 154..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 163.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it( 'should update the label correctly on item select', function () {
            var displayLabels = $( $( element ).children() ).find( 'div' ),
                defaultLabel = displayLabels[ 0 ],
                updatedlabel = displayLabels[ 1 ];
Severity: Major
Found in test/spec/zs_dropdown.js and 1 other location - About 3 hrs to fix
test/spec/zs_dropdown.js on lines 37..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        it( 'should display the default label', function () {
            var displayLabels = $( $( element ).children() ).find( 'div' ),
                defaultLabel = displayLabels[ 0 ],
                updatedlabel = displayLabels[ 1 ];
Severity: Major
Found in test/spec/zs_dropdown.js and 1 other location - About 3 hrs to fix
test/spec/zs_dropdown.js on lines 145..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        beforeEach( inject( function ( $compile ) {
            domStr = __html__[ 'test/mock_views/zs_dropdown.html' ];
            element = angular.element( domStr );
            element = $compile( element )( scope );
Severity: Major
Found in test/spec/zs_dropdown.js and 11 other locations - About 1 hr to fix
test/spec/zs_checkbox.js on lines 17..23
test/spec/zs_checkbox.js on lines 48..54
test/spec/zs_dropdown.js on lines 23..29
test/spec/zs_dropdown.js on lines 129..135
test/spec/zs_flip_card.js on lines 16..22
test/spec/zs_flip_card.js on lines 65..71
test/spec/zs_text.js on lines 28..34
test/spec/zs_text.js on lines 91..97
test/spec/zs_text.js on lines 110..116
test/spec/zs_text.js on lines 129..136
test/spec/zs_text.js on lines 454..461

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        beforeEach( inject( function ( $compile ) {
            domStr = __html__[ 'test/mock_views/zs_dropdown_multi.html' ];
            element = angular.element( domStr );
            element = $compile( element )( scope );
Severity: Major
Found in test/spec/zs_dropdown.js and 11 other locations - About 1 hr to fix
test/spec/zs_checkbox.js on lines 17..23
test/spec/zs_checkbox.js on lines 48..54
test/spec/zs_dropdown.js on lines 23..29
test/spec/zs_dropdown.js on lines 76..82
test/spec/zs_flip_card.js on lines 16..22
test/spec/zs_flip_card.js on lines 65..71
test/spec/zs_text.js on lines 28..34
test/spec/zs_text.js on lines 91..97
test/spec/zs_text.js on lines 110..116
test/spec/zs_text.js on lines 129..136
test/spec/zs_text.js on lines 454..461

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        beforeEach( inject( function ( $compile ) {
            domStr = __html__[ 'test/mock_views/zs_dropdown.html' ];
            element = angular.element( domStr );
            element = $compile( element )( scope );
Severity: Major
Found in test/spec/zs_dropdown.js and 11 other locations - About 1 hr to fix
test/spec/zs_checkbox.js on lines 17..23
test/spec/zs_checkbox.js on lines 48..54
test/spec/zs_dropdown.js on lines 76..82
test/spec/zs_dropdown.js on lines 129..135
test/spec/zs_flip_card.js on lines 16..22
test/spec/zs_flip_card.js on lines 65..71
test/spec/zs_text.js on lines 28..34
test/spec/zs_text.js on lines 91..97
test/spec/zs_text.js on lines 110..116
test/spec/zs_text.js on lines 129..136
test/spec/zs_text.js on lines 454..461

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status