Sign upLogin

zhenkyle/shadowsocks_ruby

View on GitHub
Star

Showing 27 of 37 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def initialize(argv = ARGV, stdin = $stdin, stdout = $stdout, stderr = $stderr, kernel = Kernel)
Severity: Minor
Found in lib/shadowsocks_ruby/cli/ssserver_runner.rb - About 35 mins to fix

    Method bytes_to_key1 has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def bytes_to_key1(salt, data, count, nkey, niv)
    Severity: Minor
    Found in lib/shadowsocks_ruby/cipher/cipher.rb - About 35 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(argv = ARGV, stdin = $stdin, stdout = $stdout, stderr = $stderr, kernel = Kernel)
      Severity: Minor
      Found in lib/shadowsocks_ruby/cli/sslocal_runner.rb - About 35 mins to fix

        Method tcp_receive_from_localbackend_first_packet has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def tcp_receive_from_localbackend_first_packet n
        class << self
          alias tcp_receive_from_localbackend tcp_receive_from_localbackend_other_packet
        end
        data = async_recv(-1) # first packet
        Severity: Minor
        Found in lib/shadowsocks_ruby/protocols/cipher/verify_sha1.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tcp_receive_from_remoteserver_in_buffer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def tcp_receive_from_remoteserver_in_buffer n
        if n == -1
          class << self
            alias tcp_receive_from_remoteserver tcp_receive_from_remoteserver_other_packet
          end
        Severity: Minor
        Found in lib/shadowsocks_ruby/protocols/protocol.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def build! conn
        cipher = nil

        protocols = @cfg_ary.map do | klass, params|
          case klass.to_s
        Severity: Minor
        Found in lib/shadowsocks_ruby/protocols/protocol_stack.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tcp_receive_from_localbackend_in_buffer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def tcp_receive_from_localbackend_in_buffer n
        if n == -1
          class << self
            alias tcp_receive_from_localbackend tcp_receive_from_localbackend_other_packet
          end
        Severity: Minor
        Found in lib/shadowsocks_ruby/protocols/protocol.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language