Sign upLogin

zipfworks/ember-prerender

View on GitHub
Star
lib/plugins/httpHeaders.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function beforeSend has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  beforeSend: function(req, res, page, next) {
    if (page.html) {
      var headerMatch = /<meta property=['"]prerender:([^'"]+)['"] content=['"]([^'"]+)['"]>/g;
      var head = page.html.split('</head>', 1).pop();
      var match;
Severity: Minor
Found in lib/plugins/httpHeaders.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function beforeSend has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  beforeSend: function(req, res, page, next) {
    if (page.html) {
      var headerMatch = /<meta property=['"]prerender:([^'"]+)['"] content=['"]([^'"]+)['"]>/g;
      var head = page.html.split('</head>', 1).pop();
      var match;
Severity: Minor
Found in lib/plugins/httpHeaders.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                  if (headerName === 'Location') {
                headerValue = decodeURIComponent(headerValue);
              }
    Severity: Major
    Found in lib/plugins/httpHeaders.js - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status