Showing 108 of 118 total issues
Method push has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def push(id, body)
if @queue.size > @queue_limit
raise(
SoftError,
"Queue is too long (#{@queue.size} wallets), can't add #{id}/#{Size.new(body.length)}, try again later"- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method merge has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def merge(id, copies, wallets, log)
Tempfile.open do |f|
modified = Tempfile.open do |t|
host, port = @address.split(':')
Merge.new(wallets: wallets, remotes: @remotes, copies: copies.root, log: log).run(- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method valid? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def valid?(pub, id, txn)
raise 'pub must be of type Key' unless pub.is_a?(Key)
raise 'id must be of type Id' unless id.is_a?(Id)
raise 'txn must be of type Txn' unless txn.is_a?(Txn)
pub.verify(txn.sign, body(id, txn)) && (@network != Wallet::MAINET || !id.root? || pub.root?)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method push has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def push(id, body)
raise 'Id can\'t be nil' if id.nil?
raise 'Id must be of type Id' unless id.is_a?(Id)
raise 'Body can\'t be nil' if body.nil?
start = Time.now- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(id, date, amount, prefix, bnf, details)Method text has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def text(sec)
return "#{(sec * 1_000_000).round}μs" if sec < 0.001
return "#{(sec * 1000).round}ms" if sec < 1
return "#{sec.round(2)}s" if sec < 60
return "#{(sec / 60).round}m" if sec < 60 * 60- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method reboot has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def reboot(r, json, opts)
return unless json['repo'] == Zold::REPO
mine = Semantic::Version.new(VERSION)
if mine < Semantic::Version.new(json['version'])
if opts['reboot']- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method exec has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def exec
DirItems.new(@home).fetch.each do |path|
name = File.basename(path)
next unless name =~ /^[a-f0-9]{16}#{Wallet::EXT}$/
id = Id.new(name[0..15])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method pay has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def pay(from, invoice, amount, details, opts)Method existing_copy_added has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def existing_copy_added(id, cps, score, r, json)Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(opts, wallets, remotes, copies, address, log: Log::NULL)Method start has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def start
raise 'Block must be given to start()' unless block_given?
FileUtils.mkdir_p(@dir)
DirItems.new(@dir).fetch.each do |f|
file = File.join(@dir, f)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method exec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def exec
Dir.new(@home).each do |path|
next unless path =~ /^[a-f0-9]{16}#{Wallet::EXT}$/
f = File.join(@home, path)
wallet = Wallet.new(f)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method remove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def remove(id, opts)
@wallets.acq(id, exclusive: true) do |w|
if w.exists?
File.delete(w.path)
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method exec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def exec
Dir.new(@home).each do |path|
next unless path =~ /^[a-f0-9]{16}#{Wallet::EXT}$/
f = File.join(@home, path)
lines = File.read(f).split("\n")- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def add(host, port, opts)
if opts['ignore-node'].include?("#{host}:#{port}")
@log.debug("#{host}:#{port} won't be added since it's in the --ignore-node list")
return
end- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method select has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def select(opts)
@remotes.all.shuffle.sort_by { |r| r[:errors] }.reverse.each_with_index do |r, idx|
next if idx < opts['max-nodes']
next if r[:master] && !opts['masters-too']
@remotes.remove(r[:host], r[:port])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
return "#{(days / 30).round}mo" if days < 365Avoid too many return statements within this method. Open
return "#{hours}h" if hours < 24Avoid too many return statements within this method. Open
return "#{(days / 7).round}w" if days < 40