Sign upLogin

zuzak/gov.zk

View on GitHub
Star
routes/twitter.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function getVerdict has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

const getVerdict = async (user) => {
  const username = user.screen_name
  console.log('USERNAME', username, user)

  if (user.suspended) return { verdict: 'upheld', because: 'you are suspended from Twitter' }
Severity: Minor
Found in routes/twitter.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  if (await isFollowing(username, 'countdankulatv')) return { verdict: 'upheld', because: 'the reason you were originally blocked is still true' }
Severity: Major
Found in routes/twitter.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return { verdict: 'referred', because: 'you were probably blocked manually' }
    Severity: Major
    Found in routes/twitter.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (await isFollowing('zuzakistan', username)) return { verdict: 'overturned', because: 'you have been vouched for' }
      Severity: Major
      Found in routes/twitter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (await isFollowing(username, 'lgballiance')) return { verdict: 'overturned', because: 'you were likely blocked in error' }
        Severity: Major
        Found in routes/twitter.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (await isFollowing('lgballiance', username)) return { verdict: 'overturned', because: 'you have been vouched for' }
          Severity: Major
          Found in routes/twitter.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const getUser = async (username) => {
  return new Promise((resolve, reject) => {
    twitter.get('users/lookup', { screen_name: username }, (e, r, b) => {
      if (e) reject(e)
      resolve(r)
            Severity: Major
            Found in routes/twitter.js and 1 other location - About 1 hr to fix
            routes/twitter.js on lines 39..46

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const getUserFriendship = async (username) => {
  return new Promise((resolve, reject) => {
    twitter.get('friendships/lookup', { screen_name: username }, (e, r, b) => {
      if (e) reject(e)
      resolve(r)
            Severity: Major
            Found in routes/twitter.js and 1 other location - About 1 hr to fix
            routes/twitter.js on lines 30..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 72.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status