Sign upLogin

00F100/phpatr

View on GitHub
Star

Showing 13 of 13 total issues

Function _run has a Cognitive Complexity of 183 (exceeds 5 allowed). Consider refactoring.
Open

        private function _run()
        {
            set_exception_handler(array($this, 'exceptionHandler'));
            if(empty($this->_configFile)){
                throw new ConfigFileEmptyException();
Severity: Minor
Found in src/PHPatr.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PHPatr.php has 613 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace PHPatr
{
    use Phar;
Severity: Major
Found in src/PHPatr.php - About 1 day to fix

Method _run has 206 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function _run()
        {
            set_exception_handler(array($this, 'exceptionHandler'));
            if(empty($this->_configFile)){
                throw new ConfigFileEmptyException();
Severity: Major
Found in src/PHPatr.php - About 1 day to fix

Function _parseJson has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

        private function _parseJson($required, $json)
        {
            if(is_array($required) && is_array($json)){

                $findFields = array();
Severity: Minor
Found in src/PHPatr.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                }else{
                                    $this->_error[] = 'The response of HTTP server no corresponds to a valid JSON format';
                                    $this->_error($base, $auth, $test);
                                    if($this->_debug){
Severity: Major
Found in src/PHPatr.php and 1 other location - About 4 hrs to fix
src/PHPatr.php on lines 204..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                                    if(!$this->_parseJson($assert['fields'], $json)){
                                        $this->_error[] = 'The tests[]->assert->fields does not match to test';
                                        $this->_error($base, $auth, $test);
                                        if($this->_debug){
Severity: Major
Found in src/PHPatr.php and 1 other location - About 4 hrs to fix
src/PHPatr.php on lines 245..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method _returnJson has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function _returnJson()
        {
            return '{
                            "name": "Test reqres.in",
                            "base": [
Severity: Major
Found in src/PHPatr.php - About 3 hrs to fix

PHPatr has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

    class PHPatr
    {
        const VERSION = '0.12.0';
        private $_client;
        private $_auths = array();
Severity: Minor
Found in src/PHPatr.php - About 2 hrs to fix

Method init has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function init()
        {
            $configured = false;
            $args = func_get_args();
            if($args[0] == 'index.php'){
Severity: Minor
Found in src/PHPatr.php - About 2 hrs to fix

Function init has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        public function init()
        {
            $configured = false;
            $args = func_get_args();
            if($args[0] == 'index.php'){
Severity: Minor
Found in src/PHPatr.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _parseJson has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function _parseJson($required, $json)
        {
            if(is_array($required) && is_array($json)){

                $findFields = array();
Severity: Minor
Found in src/PHPatr.php - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

                                if($value['eq'] != $json[$value['name']]){
                                    $error = true;
                                }
Severity: Major
Found in src/PHPatr.php - About 45 mins to fix

Avoid too many return statements within this method.
Open

            return $this->_run();
Severity: Major
Found in src/PHPatr.php - About 30 mins to fix
Severity
Category
Status
Source
Language