0xdade/sephiroth

View on GitHub

Showing 6 of 6 total issues

Function _process_ranges has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def _process_ranges(self, excludeip6=False):
        """
        Input: Dict of ip-ranges.json, optionally exclude ip6 ranges
        Output: Dict with header_comments and list of dicts for ip ranges
        """
Severity: Minor
Found in sephiroth/providers/file.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def main():
    args = parse_args()
    if not validate_targets(args):
        raise SystemExit
    if args.servertype in server_validators:
Severity: Minor
Found in Sephiroth.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_template has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def build_template(ranges, template, build_date, use_proxy=False, redir_target=""):
Severity: Minor
Found in Sephiroth.py - About 35 mins to fix

    Function _process_ranges has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _process_ranges(self, excludeip6=False):
            """
            Input: Dict of ip-ranges.json, optionally exclude ip6 ranges
            Output: Dict with header_comments and list of dicts for ip ranges
            """
    Severity: Minor
    Found in sephiroth/providers/asn.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _process_ranges has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def _process_ranges(self, excludeip6=False):
            """
            Input: Dict of google.csv, optionally exclude ip6 ranges
            Output: Dict with header_comments and list of dicts for ip ranges
            """
    Severity: Minor
    Found in sephiroth/providers/do.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _process_ranges has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _process_ranges(self):
            """
            Input: Dict of ip-ranges.json, optionally exclude ip6 ranges
            Output: Dict with header_comments and list of dicts for ip ranges
            """
    Severity: Minor
    Found in sephiroth/providers/linode.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language