app/admin/proposal.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [81/25]
Open

ActiveAdmin.register Proposal do
  actions :index, :show

  permit_params :status

Severity: Minor
Found in app/admin/proposal.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Pass &:status as an argument to column instead of a block.
Open

        tbl.column("Status") { |step| step.status }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Pass &:created_at as an argument to column instead of a block.
Open

        tbl.column("Created") { |step| step.created_at }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Pass &:completer as an argument to column instead of a block.
Open

        tbl.column("Completer") { |step| step.completer }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

%w-literals should be delimited by [ and ].
Open

    proposal_attributes = %w(id status created_at updated_at client_data_type public_id visit_id)
Severity: Minor
Found in app/admin/proposal.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Pass &:updated_at as an argument to column instead of a block.
Open

        tbl.column("Updated") { |step| step.updated_at }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Pass &:completed_at as an argument to column instead of a block.
Open

        tbl.column("Completed") { |step| step.completed_at }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Pass &:user as an argument to column instead of a block.
Open

        tbl.column("User") { |step| step.user }
Severity: Minor
Found in app/admin/proposal.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

There are no issues that match your filters.

Category
Status