Sign upLogin

18F/C2

View on GitHub
Star
app/admin/report.rb

Summary

Maintainability
A
15 mins
Test Coverage

Block has too many lines. [29/25]
Open

ActiveAdmin.register Report do
  permit_params :name, :query, :shared, :user_id
  hstore_editor

  form do |f|
Severity: Minor
Found in app/admin/report.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        tbl.column("Name") { |scheduled_report| link_to scheduled_report.name, admin_scheduled_report_path(scheduled_report) }
        tbl.column("Owner") { |scheduled_report| scheduled_report.user }
        tbl.column("Freqency") { |scheduled_report| scheduled_report.frequency }
Severity: Minor
Found in app/admin/report.rb and 1 other location - About 15 mins to fix
app/admin/role.rb on lines 23..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Pass &:user as an argument to column instead of a block.
Open

        tbl.column("Owner") { |scheduled_report| scheduled_report.user }
Severity: Minor
Found in app/admin/report.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Pass &:frequency as an argument to column instead of a block.
Open

        tbl.column("Freqency") { |scheduled_report| scheduled_report.frequency }
Severity: Minor
Found in app/admin/report.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

There are no issues that match your filters.

Category
Status