Sign upLogin

18F/C2

View on GitHub
Star
app/admin/step.rb

Summary

Maintainability
A
1 hr
Test Coverage

Block has too many lines. [56/25]
Open

ActiveAdmin.register Step do
  actions :index, :show, :update, :edit

  filter :status
Severity: Minor
Found in app/admin/step.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method update_step_via_status has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def update_step_via_status
      step_params = params.require(:step)
      step = resource
      if step_params[:status] == "completed"
        if step_params[:completer_id].empty?
Severity: Minor
Found in app/admin/step.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

%w-literals should be delimited by [ and ].
Open

      f.input :status, collection: %w(pending actionable completed)
Severity: Minor
Found in app/admin/step.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

There are no issues that match your filters.

Category
Status