Sign upLogin

18F/C2

View on GitHub
Star
app/controllers/api/v2/proposals_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use %i or %I for an array of symbols.
Open

      before_action -> { authorize proposal }, only: [:update, :show]
Severity: Minor
Found in app/controllers/api/v2/proposals_controller.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if proposal = create_proposal
Severity: Minor
Found in app/controllers/api/v2/proposals_controller.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

There are no issues that match your filters.

Category
Status