Sign upLogin

18F/C2

View on GitHub
Star
app/helpers/value_helper.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method has too many lines. [11/10]
Open

  def property_to_s(val)
    if decimal?(val) # assume all decimals are currency
      number_to_currency(val)
    elsif val.is_a?(ActiveSupport::TimeWithZone)
      I18n.l(val, format: :date)
Severity: Minor
Found in app/helpers/value_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method get_content_tag has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def get_content_tag(element, adjusted_time, adjusted_time_str, ago, opts)
Severity: Minor
Found in app/helpers/value_helper.rb - About 35 mins to fix

    Method get_content_tag has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def get_content_tag(element, adjusted_time, adjusted_time_str, ago, opts)
    if ago
      if !adjusted_time.today? && opts[:truncate]
        content_tag(element, adjusted_time_str, title: adjusted_time_str)
      else
    Severity: Minor
    Found in app/helpers/value_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status