app/services/proposal_update_recorder.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use value.presence || "*empty*" instead of if value.blank? "*empty*" else value end.
Open

    if value.blank?
      "*empty*"
    else
      value
    end

This cop checks code that can be written more easily using Object#presence defined by Active Support.

Example:

# bad
a.present? ? a : nil

# bad
!a.present? ? nil : a

# bad
a.blank? ? nil : a

# bad
!a.blank? ? a : nil

# good
a.presence

Example:

# bad
a.present? ? a : b

# bad
!a.present? ? b : a

# bad
a.blank? ? b : a

# bad
!a.blank? ? a : b

# good
a.presence || b

There are no issues that match your filters.

Category
Status