Sign upLogin

18F/State-TalentMAP-API

View on GitHub
Star
talentmap_api/common/common_helpers.py

Summary

Maintainability
B
5 hrs
Test Coverage

Showing 5 of 5 total issues

File common_helpers.py has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import datetime
 
from pydoc import locate
 
from dateutil.relativedelta import relativedelta
Severity: Minor
Found in talentmap_api/common/common_helpers.py - About 3 hrs to fix

    Function validate_filters_exist has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
    Open

    def validate_filters_exist(filter_list, filter_class):
        for filter in filter_list.keys():
            '''
            The filter class (a subclass of FilterSet) passed into this function has knowledge of all
            implicit and declared filters. Declared filters are those explicity instantiated (typically
    Severity: Minor
    Found in talentmap_api/common/common_helpers.py - About 55 mins to fix

    Function xml_etree_to_dict has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
    Open

    def xml_etree_to_dict(tree):
        '''
        Converts an XML etree into a dictionary.
     
        Args:
    Severity: Minor
    Found in talentmap_api/common/common_helpers.py - About 35 mins to fix

    Do not use bare 'except'
    Open

        except:
    Severity: Minor
    Found in talentmap_api/common/common_helpers.py by pep8

    Do not use bare 'except'
    Open

        except:
    Severity: Minor
    Found in talentmap_api/common/common_helpers.py by pep8
    Category
    Status